Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify makefiles, use rules directly from dpf #65

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Simplify makefiles, use rules directly from dpf #65

merged 2 commits into from
Sep 28, 2018

Conversation

falkTX
Copy link
Contributor

@falkTX falkTX commented Sep 27, 2018

I moved the rules used in 3rd party plugins directly into DPF, so I don't have to fix them in all projects at once...
A single fix in DPF can be deployed to everyone that includes DPF makefiles for building their plugins.

@falkTX
Copy link
Contributor Author

falkTX commented Sep 27, 2018

One thing that changed, the use of make USE_SYSTEM_LIBS=1 won't work anymore.
Packagers need to use make HAVE_ZITA_CONVOLVER=true which I believe makes a lot more sense, and fits into the rest of the DPF codebase checks style.

@zamaudio zamaudio merged commit b5f8a54 into zamaudio:master Sep 28, 2018
@jtojnar jtojnar mentioned this pull request Oct 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@falkTX @zamaudio