-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DND in breaks on large numbers. #13
Comments
Thank you for your help! Looking forward to a pr.
…-Zach
On Tue, Jun 28, 2022 at 10:23 AM yaki3355 ***@***.***> wrote:
Hi,
ignore my pr
not working for 20202020202020202020202020202020
—
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABH5SRPVK2AR5IKJMKS4EKLVRMRIZANCNFSM5Z6YDTWQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thanks for the help! |
BigInt's still has a max size. On my browser that limit appears to be 1024 bits. I think we might need to use something like https://github.com/Yaffle/BigInteger for integers of arbitrary size. There might be better ways to write it as well. One of the considerations was substitution of the input string into characters so that the main conversion algorithm could be employed. Since Javascript is UTF-16, that's enough space for dice of very many sides. For now, 1024 is good enough! If we decided to revisit this in the future I wanted to keep some notes. |
I'm reopening this issue because it appears to be broken? Flip in and out, output is not the same. |
Appears to be something with decimal: #?inAlph=0123456789&in=19737965684488488330219457478821781329850879392429569589875235152337186062336&outAlph=Hex |
Fixed with latest push. 54b8503 |
Probably needs to use a big int library.
https://convert.zamicol.com/?inAlph=DND%3A20&in=2020202020202020202020202020202020&outAlph=01
The text was updated successfully, but these errors were encountered: