fix: validate project name to be alphanumeric

https://zanata.atlassian.net/browse/ZNTA-197
zanata · Jul 20, 2017 · 0a0feca · 0a0feca
1 parent 8ea283a
commit 0a0feca
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 1 deletion.
diff --git a/server/zanata-war/src/main/java/org/zanata/action/ProjectHome.java b/server/zanata-war/src/main/java/org/zanata/action/ProjectHome.java
@@ -688,6 +688,28 @@ public void initialize() {
         }
     }
 
+    public void onProjectNameChange(ValueChangeEvent e) {
+        if (!isValidName((String) e.getNewValue())) {
+            String componentId = e.getComponent().getId();
+            facesMessages.addToControl(componentId,
+                    msgs.get("jsf.project.name.validation.alphanumeric"));
+        }
+    }
+
+    /**
+     * Check the name by removing any whitespaces in the string and
+     * make sure it contains at least an alphanumeric char
+     */
+    public boolean isValidName(String name) {
+        String trimmedName = StringUtils.deleteWhitespace(name);
+        for (char c : trimmedName.toCharArray()) {
+            if (Character.isDigit(c) || Character.isLetter(c)) {
+                return true;
+            }
+        }
+        return false;
+    }
+
     public void verifySlugAvailable(ValueChangeEvent e) {
         String slug = (String) e.getNewValue();
         validateSlug(slug, e.getComponent().getId());
@@ -740,6 +762,11 @@ public String update() {
                 && !getSlug().equals(getInputSlugValue())) {
             getInstance().setSlug(getInputSlugValue());
         }
+        if (!isValidName(getInstance().getName())) {
+            facesMessages.addGlobal(SEVERITY_ERROR,
+                    msgs.get("jsf.project.name.validation.alphanumeric"));
+            return null;
+        }
         boolean softDeleted = false;
         if (getInstance().getStatus() == EntityStatus.OBSOLETE) {
             softDeleted = true;
@@ -768,6 +795,11 @@ public String persist() {
             return null;
         }
         getInstance().setSlug(getInputSlugValue());
+        if (!isValidName(getInstance().getName())) {
+            facesMessages.addGlobal(SEVERITY_ERROR,
+                    msgs.get("jsf.project.name.validation.alphanumeric"));
+            return null;
+        }
         if (StringUtils.isEmpty(selectedProjectType)
                 || selectedProjectType.equals("null")) {
             facesMessages.addGlobal(SEVERITY_ERROR,

diff --git a/server/zanata-war/src/main/resources/messages.properties b/server/zanata-war/src/main/resources/messages.properties
@@ -331,6 +331,7 @@ jsf.project.WebhookName=Webhook name
 jsf.project.WebhookType.label=Type
 jsf.project.InvalidUrl=Invalid URL: {0}
 jsf.project.DuplicateUrl=Same URL is already in the list. {0}
+jsf.project.name.validation.alphanumeric=Project name must contain at least one alphanumeric character
 jsf.webhook.response.state={0}% {1}
 jsf.webhook.test.label=Test webhook
 jsf.webhook.test.tooltip=Fire a test event

diff --git a/server/zanata-war/src/main/webapp/WEB-INF/layout/project/edit_form.xhtml b/server/zanata-war/src/main/webapp/WEB-INF/layout/project/edit_form.xhtml
@@ -47,7 +47,10 @@
         <h:outputLabel for="name">#{msgs['jsf.ProjectName']}</h:outputLabel>
         <zanata:decorate id="name" componentId="nameField">
           <h:inputText id="name" required="true" maxlength="80"
-            value="#{projectHome.instance.name}">
+            value="#{projectHome.instance.name}"
+            valueChangeListener="#{projectHome.onProjectNameChange}">
+            <f:validateLength minimum="1"/>
+            <a4j:ajax event="blur" render="nameField" execute="@this"/>
           </h:inputText>
         </zanata:decorate>
       </div>