chore: enable findbugs for server module

zanata · May 24, 2017 · 0d1a03e · 0d1a03e
1 parent f13fbac
commit 0d1a03e
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 12 deletions.
diff --git a/api/pom.xml b/api/pom.xml
@@ -43,9 +43,6 @@
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>findbugs-maven-plugin</artifactId>
-        <configuration>
-          <failOnError>true</failOnError>
-        </configuration>
       </plugin>
     </plugins>
   </build>

diff --git a/build-tools/src/main/resources/zanata-build-tools/findbugs-filter.xml b/build-tools/src/main/resources/zanata-build-tools/findbugs-filter.xml
@@ -1,6 +1,8 @@
 <FindBugsFilter>
   <Match>
     <Class name="~.*\.HelpMojo" />
+  </Match>
+  <Match>
     <Source name="~.*\.kt"/>
   </Match>
 </FindBugsFilter>
diff --git a/client/pom.xml b/client/pom.xml
@@ -47,9 +47,6 @@
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>findbugs-maven-plugin</artifactId>
-        <configuration>
-          <failOnError>true</failOnError>
-        </configuration>
       </plugin>
     </plugins>
   </build>

diff --git a/common/pom.xml b/common/pom.xml
@@ -42,9 +42,6 @@
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>findbugs-maven-plugin</artifactId>
-        <configuration>
-          <failOnError>true</failOnError>
-        </configuration>
       </plugin>
     </plugins>
   </build>

diff --git a/parent/pom.xml b/parent/pom.xml
@@ -230,9 +230,7 @@
     <checkstyle.includes>*.xml,*.txt,*.md,etc/**,src/main/**,src/test/**,src/etc/**,src/conf/**</checkstyle.includes>
     <checkstyle.excludes>src/test/resources/**,**/.gitkeep</checkstyle.excludes>
 
-    <!-- NB: If we want to failOnError, we may need to
-         remove GuavaBetaDetector/library-detectors. -->
-    <findbugs.failOnError>false</findbugs.failOnError>
+    <findbugs.failOnError>true</findbugs.failOnError>
     <findbugs.excludeFilterFile>zanata-build-tools/findbugs-filter.xml</findbugs.excludeFilterFile>
     <reports-plugin.dependencyDetailsEnabled>false</reports-plugin.dependencyDetailsEnabled>
     <reports-plugin.dependencyLocationsEnabled>false</reports-plugin.dependencyLocationsEnabled>

diff --git a/server/pom.xml b/server/pom.xml
@@ -2083,6 +2083,11 @@
           </dependency>
         </dependencies>
       </plugin>
+
+      <plugin>
+        <groupId>org.codehaus.mojo</groupId>
+        <artifactId>findbugs-maven-plugin</artifactId>
+      </plugin>
     </plugins>
 
     <pluginManagement>