Refactor: use/rename constants for SourceType

zanata · Jul 13, 2018 · 211d1c6 · 211d1c6
1 parent cd549cd
commit 211d1c6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/server/gwt-editor/src/main/java/org/zanata/webtrans/client/service/TransUnitSaveService.java b/server/gwt-editor/src/main/java/org/zanata/webtrans/client/service/TransUnitSaveService.java
@@ -114,7 +114,7 @@ public void onTransUnitSave(TransUnitSaveEvent event) {
     /**
      * See {@link org.zanata.model.type.TranslationSourceType#GWT_EDITOR_ENTRY}
      */
-    private final static String sourceType = "GWT";
+    private final static String SOURCE_TYPE_GWT = "GWT";
 
     private void performSave(TransUnitId idToSave) {
         TransUnitSaveEvent forSaving = queue.getNextPendingForSaving(idToSave);
@@ -129,7 +129,7 @@ private void performSave(TransUnitId idToSave) {
         UpdateTransUnit updateTransUnit =
                 new UpdateTransUnit(new TransUnitUpdateRequest(idToSave,
                         forSaving.getTargets(), forSaving.getAdjustedStatus(),
-                        forSaving.getVerNum(), sourceType),
+                        forSaving.getVerNum(), SOURCE_TYPE_GWT),
                         TransUnitUpdated.UpdateType.WebEditorSave);
         Log.info("about to save translation: " + updateTransUnit);
         dispatcher.execute(

diff --git a/server/gwt-shared/src/main/java/org/zanata/webtrans/shared/rpc/ReplaceText.java b/server/gwt-shared/src/main/java/org/zanata/webtrans/shared/rpc/ReplaceText.java
@@ -37,7 +37,7 @@ public class ReplaceText extends UpdateTransUnit {
     /**
      * See {@link org.zanata.model.type.TranslationSourceType#GWT_EDITOR_ENTRY}
      */
-    private String sourceType = "GWT";
+    private static final String SOURCE_TYPE_GWT = "GWT";
 
     private ReplaceText() {
         super(UpdateType.NonEditorSave);
@@ -57,7 +57,8 @@ public ReplaceText(List<TransUnit> transUnits, String searchText,
         this.replaceText = replaceText;
         for (TransUnit tu : transUnits) {
             addTransUnit(new TransUnitUpdateRequest(tu.getId(),
-                    tu.getTargets(), tu.getStatus(), tu.getVerNum(), sourceType));
+                    tu.getTargets(), tu.getStatus(), tu.getVerNum(),
+                    SOURCE_TYPE_GWT));
         }
     }
 

diff --git a/server/services/src/main/java/org/zanata/rest/editor/service/TranslationService.java b/server/services/src/main/java/org/zanata/rest/editor/service/TranslationService.java
@@ -72,7 +72,7 @@ public class TranslationService implements TranslationResource {
     @Inject
     private LocaleService localeServiceImpl;
 
-    private static final String sourceType = TranslationSourceType.JS_EDITOR_ENTRY.getAbbr();
+    private static final String SOURCE_TYPE_JS_EDITOR = TranslationSourceType.JS_EDITOR_ENTRY.getAbbr();
 
     @Override
     @SuppressFBWarnings({"SLF4J_FORMAT_SHOULD_BE_CONST"})
@@ -117,7 +117,7 @@ public Response put(String localeId, TranslationData data) {
         TransUnitUpdateRequest request = new TransUnitUpdateRequest(
                 new TransUnitId(requestData.getId().longValue()),
                 requestData.getContents(), requestData.getStatus(),
-                requestData.getRevision(), sourceType);
+                requestData.getRevision(), SOURCE_TYPE_JS_EDITOR);
         if (revisionComment != null) {
             request.addRevisionComment(revisionComment);
         }