feat(ZNTA-2156) revert styling changes that are inconsistent with rej…

…ect translations admin screen
zanata · Aug 23, 2017 · 247b672 · 247b672
1 parent b01d835
commit 247b672
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 15 deletions.
diff --git a/...src/frontend/app/editor/components/RejectTranslationModal/RejectTranslationModal.story.js b/...src/frontend/app/editor/components/RejectTranslationModal/RejectTranslationModal.story.js
@@ -23,16 +23,15 @@ storiesOf('RejectTranslationModal', module)
     ))
     .add('Translation errors [critical]', () => (
         <RejectTranslationModal show
-         criteria={<span><strong>Translation Errors</strong> (terminology,
-         mistranslated addition, omission, un-localized, do not translate, etc)</span>}
+         criteria="Translation Errors (terminology, mistranslated addition, omission, un-localized, do not translate, etc)"
          priority="Critical"  textState="u-textDanger" />
     ))
     .add('Style Guide and Glossary Violations [minor]', () => (
-        <RejectTranslationModal show criteria={<span><strong>Style Guide and Glossary Violations</strong></span>} priority="Minor" />
+        <RejectTranslationModal show criteria="Style Guide and Glossary Violations" priority="Minor" />
     ))
 
     .add('Other [major]', () => (
         <RejectTranslationModal show
-         criteria={<span><strong>Other</strong> (reason may be in comment section/history if necessary)</span>}
+         criteria="Other (reason may be in comment section/history if necessary)"
          priority="Major" textState="u-textWarning" />
     ))
diff --git a/server/zanata-frontend/src/frontend/app/editor/components/RejectTranslationModal/index.css b/server/zanata-frontend/src/frontend/app/editor/components/RejectTranslationModal/index.css
@@ -38,10 +38,6 @@
   flex-grow: 2;
 }
 
-.criteria strong {
-  font-weight: 600;
-}
-
 a.Dropdown-item span.s0 {
   vertical-align: var(--TM-icon-vert-alignment);
   margin-left: var(--TM-small-margin);

diff --git a/server/zanata-frontend/src/frontend/app/editor/components/RejectTranslationModal/index.js b/server/zanata-frontend/src/frontend/app/editor/components/RejectTranslationModal/index.js
@@ -29,7 +29,7 @@ export class RejectTranslationModal extends Component {
             'u-textDanger'
         ]
     ),
-    criteria: PropTypes.object
+    criteria: PropTypes.string.isRequired
   }
 
   constructor (props) {
@@ -91,18 +91,18 @@ export class RejectTranslationModal extends Component {
             <Dropdown.Content>
               <ul>
                 <li className="Dropdown-item" onClick={this.toggleDropdown}>
-                  <strong>Translation Errors</strong> (terminology, mistranslated, addition, omission, un-localized, do not translate, etc)</li>
+                  Translation Errors (terminology, mistranslated, addition, omission, un-localized, do not translate, etc)</li>
                 <li className="Dropdown-item" onClick={this.toggleDropdown}>
-                  <strong>Language Quality</strong> (grammar, spelling, punctuation, typo, ambiguous wording, product name, sentence structuring,
+                  Language Quality (grammar, spelling, punctuation, typo, ambiguous wording, product name, sentence structuring,
                   readability, word choice, not natural, too literal, style and tone, etc)
                 </li>
                 <li className="Dropdown-item" onClick={this.toggleDropdown}>
-                  <strong>Consistency</strong> (inconsistent style or vocabulary, brand inconsistency, etc.)</li>
-                <li className="Dropdown-item" onClick={this.toggleDropdown}><strong>Style Guide & Glossary Violations</strong></li>
+                  Consistency (inconsistent style or vocabulary, brand inconsistency, etc.)</li>
+                <li className="Dropdown-item" onClick={this.toggleDropdown}>Style Guide & Glossary Violations</li>
                 <li className="Dropdown-item" onClick={this.toggleDropdown}>
-                  <strong>Format</strong> (mismatches, white-spaces, tag error or missing, special character, numeric format, truncated, etc.)</li>
+                  Format (mismatches, white-spaces, tag error or missing, special character, numeric format, truncated, etc.)</li>
                 <li className="Dropdown-item" onClick={this.toggleDropdown}>
-                  <strong>Other</strong> (reason may be in comment section/history if necessary)</li>
+                  Other (reason may be in comment section/history if necessary)</li>
               </ul>
             </Dropdown.Content>
           </Dropdown>