Skip to content

Commit

Permalink
refactor: add FIXME comment for fragile css rule
Browse files Browse the repository at this point in the history
I forgot to edit my reminder comment before and it was removed. This
replaces it with a more useful comment.
  • Loading branch information
davidmason committed Aug 8, 2017
1 parent 9705ad7 commit 27830a8
Showing 1 changed file with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -600,6 +600,14 @@ button.close:focus, button.close:hover, button.close:active:focus {
color: #f00;
}

/* This rule looks fragile - 5 different things needed to trigger it, and they
* do not look related to the adjustment:
* .Link--neutral is just color
* .row is just displaying as table cell
* .u-ltemd-hidden is just hiding on non-large screens
*
* FIXME use a utility class for this adjustment instead. Probably
* .u-vAlignSuper, which could go next to .u-vAlignMiddle in utils-display */
button.Link--neutral .row span.u-ltemd-hidden {
vertical-align:super;
}
Expand Down

0 comments on commit 27830a8

Please sign in to comment.