fix: unique html id for checkbox (#848)

https://zanata.atlassian.net/browse/ZNTA-2549
zanata · May 28, 2018 · e9f9ed7 · e9f9ed7
1 parent c6f3d7d
commit e9f9ed7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/server/zanata-war/src/main/webapp/WEB-INF/layout/project/languages-list.xhtml b/server/zanata-war/src/main/webapp/WEB-INF/layout/project/languages-list.xhtml
@@ -42,7 +42,7 @@
   <div class="#{ empty languages ? 'is-hidden' : ''}">
 
     <div class="is-hidden--s l--pad-v-quarter">
-      <zanata:select-all-checkbox listSelector="##{id}-list"/>
+      <zanata:select-all-checkbox listSelector="##{id}-list" id="#{id}"/>
       <div class="l--pad-left-1half">
         <div class="g g--tight js-list-operation"
           data-target-list="##{id}-list"

diff --git a/server/zanata-war/src/main/webapp/resources/zanata/select-all-checkbox.xhtml b/server/zanata-war/src/main/webapp/resources/zanata/select-all-checkbox.xhtml
@@ -30,12 +30,12 @@
     }
   </h:outputScript>
   <div class="form__checkbox js-form__checkbox #{cc.attrs.styleClass}">
-    <input type="checkbox" id="form-checkbox-1"
+    <input type="checkbox" id="form-checkbox-#{cc.attrs.id}"
       class="form__checkbox__input js-form__checkbox__input"
       data-list-selector="#{cc.attrs.listSelector}"
       name="form-checkbox"
       onchange="#{cc.attrs.id}Selected($(this))"/>
-    <label for="form-checkbox-1"
+    <label for="form-checkbox-#{cc.attrs.id}"
       class="form__checkbox__label">#{cc.attrs.label}</label>
   </div>
 </composite:implementation>