Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unique html id for checkbox #848

Merged
merged 1 commit into from
May 28, 2018
Merged

Conversation

alex-sl-eng
Copy link
Member

https://zanata.atlassian.net/browse/ZNTA-2549

JIRA issue URL: paste URL here

[description]

Checklist

  • JIRA link
  • Check target branch
  • Make sure all commit statuses are green or otherwise documented reasons to ignore
  • QA needs to evaluate against the JIRA ticket
  • Changed files and commits make sense for this PR

See Zanata Development Guidelines more for information.


This template can be updated in .github/PULL_REQUEST_TEMPLATE.md

@zubot
Copy link
Member

zubot commented May 25, 2018

This change is Reviewable

@huangp
Copy link
Contributor

huangp commented May 25, 2018

-(Awaiting review) +Reviewed +(On QA)


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@codecov
Copy link

codecov bot commented May 25, 2018

Codecov Report

Merging #848 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #848   +/-   ##
========================================
  Coverage        34%     34%           
  Complexity     5921    5921           
========================================
  Files          1613    1613           
  Lines         64341   64341           
  Branches       7503    7503           
========================================
  Hits          21876   21876           
  Misses        40482   40482           
  Partials       1983    1983

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f992d75...5a0e1a3. Read the comment docs.

@spathare21 spathare21 added Verified and removed On QA labels May 25, 2018
@spathare21
Copy link
Member

is this targeted for release or master ?

@alex-sl-eng alex-sl-eng merged commit 2f5c1a7 into master May 28, 2018
@alex-sl-eng alex-sl-eng deleted the ZNTA-2549-checkbox-id branch May 28, 2018 00:19
@alex-sl-eng
Copy link
Member Author

cherry-picked into release manually.

dragosv pushed a commit to dragosv/zanata-platform that referenced this pull request May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants