Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase JS heap #1032

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Increase JS heap #1032

merged 2 commits into from
Aug 23, 2018

Conversation

seanf
Copy link
Contributor

@seanf seanf commented Aug 23, 2018

JIRA issue URL: paste URL here

Apparently the default for Node is 1.76GB on 64 bit machines: https://stackoverflow.com/questions/47381275/why-does-node-js-have-an-1-76-gb-memory-limit?rq=1

This change increases it to 4GB when built via Jenkins.

Checklist

  • JIRA link
  • Check target branch
  • Make sure all commit statuses are green or otherwise documented reasons to ignore
  • QA needs to evaluate against the JIRA ticket
  • Changed files and commits make sense for this PR

See Zanata Development Guidelines more for information.


This template can be updated in .github/PULL_REQUEST_TEMPLATE.md

@zubot
Copy link
Member

zubot commented Aug 23, 2018

This change is Reviewable

Copy link
Contributor

@djansen-redhat djansen-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@djansen-redhat
Copy link
Contributor

@seanf NO_QA, rebuild maybe 3-5 times and go?

@codecov
Copy link

codecov bot commented Aug 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@69ebf6b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1032   +/-   ##
=========================================
  Coverage          ?   36.99%           
  Complexity        ?     6153           
=========================================
  Files             ?     1647           
  Lines             ?    65376           
  Branches          ?     7615           
=========================================
  Hits              ?    24184           
  Misses            ?    39094           
  Partials          ?     2098

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ebf6b...13c2524. Read the comment docs.

Copy link
Member

@alex-sl-eng alex-sl-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@alex-sl-eng alex-sl-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@seanf
Copy link
Contributor Author

seanf commented Aug 23, 2018

@djansen-redhat That's five builds in a row where the frontend module has finished without "JavaScript heap out of memory".

@seanf seanf merged commit beeeb8e into master Aug 23, 2018
@seanf seanf deleted the more-js-heap branch August 23, 2018 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants