-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase JS heap #1032
Increase JS heap #1032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
@seanf NO_QA, rebuild maybe 3-5 times and go? |
Codecov Report
@@ Coverage Diff @@
## master #1032 +/- ##
=========================================
Coverage ? 36.99%
Complexity ? 6153
=========================================
Files ? 1647
Lines ? 65376
Branches ? 7615
=========================================
Hits ? 24184
Misses ? 39094
Partials ? 2098 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
@djansen-redhat That's five builds in a row where the frontend module has finished without "JavaScript heap out of memory". |
JIRA issue URL: paste URL here
Apparently the default for Node is 1.76GB on 64 bit machines: https://stackoverflow.com/questions/47381275/why-does-node-js-have-an-1-76-gb-memory-limit?rq=1
This change increases it to 4GB when built via Jenkins.
Checklist
See Zanata Development Guidelines more for information.
This template can be updated in .github/PULL_REQUEST_TEMPLATE.md