Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade typescript version #1031

Closed
wants to merge 1 commit into from
Closed

Conversation

alex-sl-eng
Copy link
Member

@alex-sl-eng alex-sl-eng commented Aug 23, 2018

JIRA issue URL: paste URL here

downgrade typescript version due to memory issue:

PR when upgrading: #1022
Related discussion: microsoft/TypeScript#17112 (comment)

Checklist

  • JIRA link
  • Check target branch
  • Make sure all commit statuses are green or otherwise documented reasons to ignore
  • QA needs to evaluate against the JIRA ticket
  • Changed files and commits make sense for this PR

See Zanata Development Guidelines more for information.


This template can be updated in .github/PULL_REQUEST_TEMPLATE.md

@alex-sl-eng alex-sl-eng self-assigned this Aug 23, 2018
@zubot
Copy link
Member

zubot commented Aug 23, 2018

This change is Reviewable

@djansen-redhat
Copy link
Contributor

@aeng @seanf Shouldn't we have some Jira issue, details or otherwise to record why this was necessary?

@codecov
Copy link

codecov bot commented Aug 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@69ebf6b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1031   +/-   ##
=========================================
  Coverage          ?   36.99%           
  Complexity        ?     6153           
=========================================
  Files             ?     1647           
  Lines             ?    65376           
  Branches          ?     7615           
=========================================
  Hits              ?    24184           
  Misses            ?    39094           
  Partials          ?     2098

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ebf6b...f553e9c. Read the comment docs.

@seanf
Copy link
Contributor

seanf commented Aug 23, 2018

@aeng @djansen-redhat See #1032 for another experiment

@seanf
Copy link
Contributor

seanf commented Aug 23, 2018

@aeng The first master build I can find which failed due to "JavaScript heap out of memory" was for this commit: 8b50de8

Four days before TypeScript 3 went in. So TS 3 is not the culprit at all.

@alex-sl-eng
Copy link
Member Author

See #1032 for solution.

@seanf seanf deleted the downgrade-typescript branch August 23, 2018 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants