-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ZNTA-2610): upgrade react to 16.4.0 #882
Conversation
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
============================================
- Coverage 36.44% 36.41% -0.03%
Complexity 6002 6002
============================================
Files 1626 1627 +1
Lines 64193 64233 +40
Branches 7470 7474 +4
============================================
- Hits 23395 23393 -2
- Misses 38757 38800 +43
+ Partials 2041 2040 -1
Continue to review full report at Codecov.
|
Reviewed 7 of 10 files at r1, 11 of 11 files at r2. Comments from Reviewable |
This seems to break the glossary entry details button
|
I'll have to check, but I think this may also break pagination on the explore page (page not incremented) |
Breaks language page delete function
|
@djansen-redhat Looks like that error is caused by the react-bootstrap modal: |
…-upgrade-16/ZNTA-2610
…-upgrade-16/ZNTA-2610
…-upgrade-16/ZNTA-2610
…-upgrade-16/ZNTA-2610
Verified |
JIRA issue URL: https://zanata.atlassian.net/browse/ZNTA-2610
Upgrade React to 16.4.0
Upgrade all affected packages.
Resolve new Jest warnings.
Checklist
See Zanata Development Guidelines more for information.
This template can be updated in .github/PULL_REQUEST_TEMPLATE.md