Ensure use of InnoDB engine on MySQL #773
Conversation
|
👍 |
|
@carlosmunoz I'd like your opinion on this. |
| for (int i = 0; i < sqls.length; i++) { | ||
| Sql sql = sqls[i]; | ||
| String sqlText = sql.toSql(); | ||
| String sqlUpper = sqlText.toUpperCase(); |
There was a problem hiding this comment.
How about a .trim() just in case?
|
Looks good in general terms. We are making some assumptions about the sql string, but I guess the check that you've added can raise a red flag if there are non-InnoDB tables in the midst. |
|
@carlosmunoz note that this is targeting |
|
✅ Tested update and halt on !InnoDB |
|
@djansen-redhat @aeng @carlosmunoz I have added a custom error message for the precondition check. |
|
When I tested it again, I couldn't find any evidence that Liquibase was picking up the "ensure InnoDB" extension(!). I had to move it to its own jar before Liquibase would register it. I've also added another extension which logs before executing each change, which should help a little with https://bugzilla.redhat.com/show_bug.cgi?id=1207980 |
|
Is there a bug report related to this? |
|
|
👍 on 6b111cc |
|
@carlosmunoz How do you feel about the new module under zanata-server, ie zanata-liquibase? I'm hoping we'll be able to move our changelogs and custom changes into that module too, which would make it easier to run liquibase from the command line. |
|
I don't mind it... although it looks small for the time being. If we end up moving the changelogs, will liquibase be able to read them from inside a jar? or will we need two artifacts. In the later case, I would rather keep the changelogs where they currently reside. |
|
On 2015-04-23 00:53, Carlos Munoz wrote:
Yes, liquibase is supposed to be able to read changelogs from a jar. Sean Flanigan Principal Software Engineer |
|
Test:
|
|
@djansen-redhat: regarding your checklist:
|
|
✅ Tested |
|
@carlosmunoz are you happy with c69d8ec? |
|
👍 |
|
I need to double check that the new extension is indeed logging changeset IDs before executing them (unless someone beats me to it). |
Ensure use of InnoDB engine on MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1207575