Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setOptions after creation and more specific types #3

Merged
merged 2 commits into from
Dec 12, 2019

Conversation

PabloSzx
Copy link
Contributor

@PabloSzx PabloSzx commented Dec 3, 2019

When I was using this library (very useful, thank you very much) I realized I had to make a new instance of the test client every time I had to change any option, so I made this change, and it works perfectly, as I tested it in my fork.

Also, I found a couple of easy type safety improvements to be made.

@vitorbal
Copy link
Contributor

vitorbal commented Dec 5, 2019

Thanks, this makes sense to me! Could you also add some documentation to the README so folks know about this feature? Thanks in advance!

@vitorbal vitorbal added the enhancement New feature or request label Dec 5, 2019
@PabloSzx
Copy link
Contributor Author

PabloSzx commented Dec 6, 2019

@vitorbal I added documentation, updated dependencies and moved TypeScript to devDependencies.

I also mentioned graphql-tag-ts (module augmentation of graphql-tag) in the documentation since I added support for this library.

@vitorbal
Copy link
Contributor

@PabloSzx thanks for the docs, they look very good!

If it's okay by you, I'd prefer if we keep the typescript section out of this PR, to keep the docs focused on the purpose of the library.

I took a look at graphql-tag-ts though and it looks really cool! I'm going to try it out at work once I have a chance 🙂

@PabloSzx
Copy link
Contributor Author

@vitorbal done

Copy link
Contributor

@vitorbal vitorbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM 👍

@vitorbal vitorbal merged commit 7f2133f into zapier:master Dec 12, 2019
@vitorbal
Copy link
Contributor

Published as apollo-server-integration-testing@2.3.0. Thanks again for your contribution, @PabloSzx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants