Localized regular expressions, without needing pyyaml #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the first locale, IT, that we care for right now Needed improvements include a better way to package the local regular expressions
Add the first locale, IT, that we care for right now Needed improvements include a better way to package the local regular expressions
tests for all locales
- Is this what travis is really complaining about? Fix _test_test file name error for italian test
Based on PR #18, modified to no longer require pyyaml This keeps email_reply_parser stdlib only, and allows easy addition of new locales without needing to parse config files
|
I realized this is diverted from master, I will take a look at rebuilding these changes against the current codebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the prior work done by @kulpreet, converted to no longer need pyyaml
I made this change because this library currently uses only the standard python libraries, and I feel as though that is a positive for our library, and we shouldn't change it unless we absolutely have to