Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some sample emails which inconveniently leave off anglebrackets #6

Closed
wants to merge 3 commits into from

Conversation

eoghanmurray
Copy link

I extracted these sample emails from a corpus of email exchanges.

I'm not sure if this is a direction you want to go with email-reply-parser (the only danger I could see would be if INLINE_WROTE matched falsely: eoghanmurray@64754e2), but this sort of thing definitely exists 'in the wild'!

Eoghan

@roycehaynes
Copy link
Contributor

@eoghanmurray - thanks for contributing! Looked at your code briefly. I don't see anything alarming. You're basically adding carrots when they don't exist after a match is made on the INLINE_WROTE.

Do you know what happens when INLINE_WROTE doesn't match, but the e-mail chain doesn't contain carrots?

@ierror
Copy link

ierror commented Jul 3, 2014

any updates here?

@eoghanmurray
Copy link
Author

Do you know what happens when INLINE_WROTE doesn't match, but the e-mail chain doesn't contain carrots?

Not sure what you mean by 'carrots'!

The file test/emails/email_inline_wrote.txt shows an example where the angle brackets on 'Yep, I would still be interested' would get doubled (as intended). If that line didn't start with an angle bracket, it wouldn't get doubled, but that'd be okay as we are just trying to isolate the most recent mail, no?

@roycehaynes roycehaynes closed this May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants