Pre-compile regular expressions before being used

[mattrobenolt]

No description provided.

[mattrobenolt]

bump

[ierror]

any progress here?

[mattrobenolt]

damn

[bryanhelmig]

Yeah, this seemed like a decent patch. Any reason for the close instead of the merge?

Setting aside the fact that we haven't paid attention to this package for ... oh, 3 years ... 👀

[roycehaynes]

@mattrobenolt - To be fair, this is a decent patch looking at the PR. Definitely worthy of reopen and merge....

[roycehaynes]

@mattrobenolt 6 tests failed after merge (should have ran locally before merging). Looking at this now, but may want to give your impl a second peep.

[roycehaynes]

You can run tests by python from root dir python tests/test_email_reply_parser.py

[kageurufu]

Python caches compiled regex regardless the first time they are compiled or used, unless this adds something on top of that I didn't see it as that important.

This will, however, potentially save a function call and dictionary lookup in practice