docs(core) Use response.json where possible
#200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FokkeZB
commented
Apr 13, 2020
Comment on lines
-2033
to
-2036
| const autoParseJson = (response, z, bundle) => { | ||
| response.json = z.JSON.parse(response.content); | ||
| return response; | ||
| }; |
There was a problem hiding this comment.
This example middleware was just overriding the already set response.json so IMO did not have much value as example and fortunately we have another afterResponse example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally included some of these in #193 but figured it was better done in a separate PR.
AFAIK unless you set
raw:trueyou can useresponse.jsoninstead ofz.JSON.parse(response.content)so I guess we want to promote that more simple shortcut as much as we can.