Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs) - Add documentation for PKCE OAuth2 #629

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

standielpls
Copy link
Contributor

Updates the Authentication to include a section on PKCE for OAuth2.

eliangcs
eliangcs previously approved these changes Mar 6, 2023
Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a suggestion on mentioning on which version we start to support PKCE. Otherwise, it looks good to me! Thanks!

@@ -443,6 +443,33 @@ Also, `authentication.oauth2Config.getAccessToken` has access to the additional

If you define `fields` to collect additional details from the user, please note that `client_id` and `client_secret` are reserved keys and cannot be used as keys for input form fields.


### OAuth2 with PKCE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be worth mentioning which version supports PKCE:

Suggested change
### OAuth2 with PKCE
### OAuth2 with PKCE
*Added in v14.0.0.*

@standielpls standielpls merged commit f8ade5f into main Mar 6, 2023
@standielpls standielpls deleted the pde-3244/pkce-documentation branch March 6, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants