Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the Connection given to InitializationPlugin be Closeable? #8

Closed
victornoel opened this issue Mar 25, 2017 · 2 comments
Closed

Should the Connection given to InitializationPlugin be Closeable? #8

victornoel opened this issue Mar 25, 2017 · 2 comments
Milestone
1.0

Comments

@victornoel
Copy link

victornoel commented Mar 25, 2017 •
edited
Loading

I understood that InitializationPlugin.getConnection() returned Connection that couldn't be closed for the duration of the test.

But I noticed that when implementing InitializationPlugin.connectionMade, the Connection that was passed to it could be closed.

Is that on purpose? Could it be the reason behind #7?
@victornoel victornoel mentioned this issue Mar 25, 2017
Closed
@zapodot
Copy link
Owner

zapodot commented Mar 26, 2017

Hi again @victornoel and thank you for reporting back this issue. You were right to assume that this was indeed a bug. For the sake of consistency the InititializationPlugin should be given the same sort of connection as is provided to the tests. I have created a fix and will push it shortly. It should also solve #7, but keeps it open until you have confirmed it.

zapodot added a commit that referenced this issue Mar 26, 2017
@zapodot
Make sure that the InititalizationPlugin is provided with the same so…
e5fa71b 
…rt of connection (where close() is surpressed) as the tests are. Solves #8
@zapodot zapodot closed this as completed Mar 26, 2017
@zapodot zapodot modified the milestone: 1.0 Mar 26, 2017
@zapodot
Copy link
Owner

zapodot commented Mar 26, 2017

Just released this fix as part of version 1.0-RC1. If no new major issues appear you can expect a 1.0 release in a few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@victornoel @zapodot