Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding error that occurs when reading readme #1050

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

xncbf
Copy link
Contributor

@xncbf xncbf commented Oct 1, 2021

If you use a language other than English in Windows environment (2 bytes languages), cp949 error occurs during installation

[pipenv.exceptions.InstallError]:     Complete output (5 lines):
[pipenv.exceptions.InstallError]:     Traceback (most recent call last):
[pipenv.exceptions.InstallError]:       File "<string>", line 1, in <module>
[pipenv.exceptions.InstallError]:       File "C:\Users\AppData\Local\Temp\pip-install-soudjjra\zappa_0b8c2fb4266844e8bbe754fa82cfb4f2\setup.py", line 8, in <module>
[pipenv.exceptions.InstallError]:         long_description = readme_file.read()
[pipenv.exceptions.InstallError]:     UnicodeDecodeError: 'cp949' codec can't decode byte 0xe3 in position 73845: illegal multibyte sequence

Copy link
Member

@javulticat javulticat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants