Decode zappa invoke output regardless of --no-color option
#1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellno
previously approved these changes
Nov 8, 2021
|
@hellno TFTR! Let me know if you think this needs a test before you can merge it; I see that coverage went down but I didn't see any existing test that this could fit into neatly. |
rolandcrosby-check
force-pushed
the
no-color-decode
branch
from
ba59970
to
0a4f9e9
Compare
|
Slightly refactored and added a test so this should no longer cause issues with reduced coverage. |
wrboyce
approved these changes
Nov 12, 2021
When a user calls `zappa invoke` or `zappa manage`, always decode the output's `LogResult` as UTF-8, regardless of whether the use has specified `--no-color`. If the output cannot be decoded as UTF-8, fall back to printing the raw bytes as a `b''` literal. Also disables colorization if the output is not being written to a terminal.
rolandcrosby-check
force-pushed
the
no-color-decode
branch
from
0a4f9e9
to
8f43895
Compare
|
@wrboyce Just resolved the merge conflict; let me know if you need anything else from me to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user calls
zappa invokeorzappa manage, always decode the output'sLogResultas UTF-8, regardless of whether the use has specified--no-color. If the output cannot be decoded as UTF-8, fall back to printing the raw bytes as ab''literal.Also disables colorization if the output is not being written to a terminal.
GitHub Issues
Fixes #1068.