-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert project to using 'pipenv' to manage dependencies #1077
Conversation
b28353b
to
b84e262
Compare
69fef44
to
b5fcf1c
Compare
b5fcf1c
to
0c65a7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love this! thanks for the PR 💪🏼 much easier to maintain this way (at least to my mind)
I assume you didn't commit the Pipfile.lock
on purpose. Is it not needed in this case? (From other projects I'm used to adding it, but that might not be the best way to go 😊)
Basically my question is: are the dependencies fixed enough without having Pipfile.lock
?
@hellno, I didn't commit
|
Love it! The many python versions + less clutter makes a lot of sense 👍🏼 |
Description
Converts the project to use
pipenv
to manage dependencies, as discussed in Slack.