Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert project to using 'pipenv' to manage dependencies #1077

Merged
merged 8 commits into from
Nov 22, 2021

Conversation

javulticat
Copy link
Member

Description

Converts the project to use pipenv to manage dependencies, as discussed in Slack.

@javulticat javulticat self-assigned this Nov 12, 2021
@javulticat javulticat force-pushed the jav/pipenv branch 6 times, most recently from b28353b to b84e262 Compare November 12, 2021 03:29
@javulticat javulticat force-pushed the jav/pipenv branch 2 times, most recently from 69fef44 to b5fcf1c Compare November 12, 2021 04:06
@coveralls
Copy link

coveralls commented Nov 12, 2021

Coverage Status

Coverage remained the same at 73.292% when pulling 9d54747 on javulticat:jav/pipenv into eda8c48 on zappa:master.

Copy link
Collaborator

@hellno hellno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this! thanks for the PR 💪🏼 much easier to maintain this way (at least to my mind)

I assume you didn't commit the Pipfile.lock on purpose. Is it not needed in this case? (From other projects I'm used to adding it, but that might not be the best way to go 😊)

Basically my question is: are the dependencies fixed enough without having Pipfile.lock?

Pipfile Outdated Show resolved Hide resolved
@javulticat
Copy link
Member Author

love this! thanks for the PR 💪🏼 much easier to maintain this way (at least to my mind)

I assume you didn't commit the Pipfile.lock on purpose. Is it not needed in this case? (From other projects I'm used to adding it, but that might not be the best way to go 😊)

Basically my question is: are the dependencies fixed enough without having Pipfile.lock?

@hellno, I didn't commit Pipfile.lock in this case because the lock file is specific to a single version of Python, whereas Zappa supports Py 3.6 - 3.9. Our options would seem to be either:

  1. Commit 1 lock file per version of Python we support
  2. Don't commit any lock file, and rely on having dependencies pinned/bounded appropriately in Pipfile (this is the approach I went with as it minimized clutter in the repo)

@hellno
Copy link
Collaborator

hellno commented Nov 22, 2021

Love it! The many python versions + less clutter makes a lot of sense 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants