Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check isort in CI #1078

Merged
merged 5 commits into from
Nov 12, 2021
Merged

Check isort in CI #1078

merged 5 commits into from
Nov 12, 2021

Conversation

javulticat
Copy link
Member

@javulticat javulticat commented Nov 12, 2021 •
edited
Loading

Description

We have isort, but aren't actually enforcing its use. This PR ensures we are checking isort in our CI.

Note: all .py files in this PR were modified by isort, not manually.

@javulticat javulticat self-assigned this Nov 12, 2021
@coveralls
Copy link

coveralls commented Nov 12, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 73.251% when pulling 3e6ff13 on javulticat:jav/isort-everywhere into ca8ca63 on zappa:master.

@javulticat javulticat merged commit a21b5ae into zappa:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrboyce wrboyce wrboyce approved these changes

@hellno hellno Awaiting requested review from hellno

Assignees

@javulticat javulticat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javulticat @coveralls @wrboyce