Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure unique scheduled event names #1080

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Ensure unique scheduled event names #1080

merged 2 commits into from
Nov 16, 2021

Conversation

javulticat
Copy link
Member

Description

Ensure event names are unique. To do so, the process of creating event names was streamlined to make it easier to follow.

GitHub Issues

#854

@javulticat javulticat self-assigned this Nov 12, 2021
@coveralls
Copy link

coveralls commented Nov 12, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 73.292% when pulling 2fc807c on javulticat:jav/854 into a21b5ae on zappa:master.

@edudobay
Copy link

see also #2 which solves the same issue.

hellno
hellno approved these changes Nov 13, 2021
View reviewed changes
Copy link
Collaborator

@hellno hellno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@javulticat javulticat merged commit eda8c48 into zappa:master Nov 16, 2021
@edudobay edudobay mentioned this pull request Nov 25, 2021
Closed
@javulticat javulticat mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellno hellno hellno approved these changes

@wrboyce wrboyce Awaiting requested review from wrboyce

Assignees

@javulticat javulticat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@javulticat @coveralls @edudobay @hellno