Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Handle V2 Event #1182

Closed

Conversation

rehanhwr
Copy link

Description

Handle v2 formatted event coming from HTTP API Gateway or Lambda Function URL.

GitHub Issues

#1121
#851

@sridhar562345
Copy link
Contributor

@rehanhwr Did you verify the request format when custom stage is added on http api instead of $default?

@rehanhwr
Copy link
Author

@rehanhwr Did you verify the request format when custom stage is added on http api instead of $default?

@sridhar562345 the format is the same, however the path value in the event is different because it'll include stage name as prefix. this could be solved by setting the base_path in the zappa settings to strip out the prefix from the path

Copy link
Collaborator

@monkut monkut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick look and some brief comments to start this moving forward.

zappa/handler.py Outdated Show resolved Hide resolved
zappa/handler.py Outdated Show resolved Hide resolved
zappa/handler.py Outdated Show resolved Hide resolved
zappa/handler.py Outdated Show resolved Hide resolved
zappa/wsgi.py Outdated Show resolved Hide resolved
@rehanhwr rehanhwr requested a review from monkut October 20, 2022 03:44
@coveralls
Copy link

coveralls commented Oct 22, 2022

Coverage Status

Coverage decreased (-0.09%) to 74.456% when pulling ec823b5 on rehanhwr:handler-for-v2.0-formatted-event into 73ee393 on zappa:master.

Copy link
Collaborator

@monkut monkut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need some more time to take a look at this, but I've commented a bit more.

zappa/handler.py Show resolved Hide resolved
zappa/wsgi.py Outdated Show resolved Hide resolved
@rehanhwr rehanhwr force-pushed the handler-for-v2.0-formatted-event branch 2 times, most recently from ad52097 to a000bee Compare October 22, 2022 16:41
@rehanhwr rehanhwr force-pushed the handler-for-v2.0-formatted-event branch from 2c5e697 to 69f3b71 Compare October 22, 2022 17:15
@monkut
Copy link
Collaborator

monkut commented Nov 13, 2022

@rehanhwr Can you run make black / make isort on this?

@rehanhwr
Copy link
Author

@rehanhwr Can you run make black / make isort on this?

will update it soon

@rehanhwr rehanhwr requested a review from monkut November 16, 2022 14:38
zappa/wsgi.py Outdated Show resolved Hide resolved
zappa/wsgi.py Outdated Show resolved Hide resolved
zappa/wsgi.py Outdated Show resolved Hide resolved
zappa/wsgi.py Outdated Show resolved Hide resolved
zappa/wsgi.py Outdated Show resolved Hide resolved
@rehanhwr rehanhwr requested a review from monkut November 29, 2022 15:46
@sridhar562345
Copy link
Contributor

@monkut can we merge this in next release?

@harshild
Copy link

@monkut @rehanhwr - Do let me know what's left to get this PR through. I can contribute

@justinwride
Copy link

I am very interested in this functionality 🙏 Please update what needs to happen for this to be merged.

Copy link

github-actions bot commented Apr 3, 2024

Hi there! Unfortunately, this PR has not seen any activity for at least 90 days. If the PR is still relevant to the latest version of Zappa, please comment within the next 10 days if you wish to keep it open. Otherwise, it will be automatically closed.

@github-actions github-actions bot added the no-activity [Bot] Closing soon if no new activity label Apr 3, 2024
Copy link

Hi there! Unfortunately, this PR was automatically closed as it had not seen any activity in at least 100 days. If the PR is still relevant to the latest version of Zappa, please open a new PR.

@github-actions github-actions bot added the auto-closed [Bot] Closed, details in comments label Apr 13, 2024
@github-actions github-actions bot closed this Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-closed [Bot] Closed, details in comments no-activity [Bot] Closing soon if no new activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants