Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing compatibility with Django 4.2 #1237

Merged
merged 2 commits into from
May 16, 2023
Merged

fixing compatibility with Django 4.2 #1237

merged 2 commits into from
May 16, 2023

Conversation

dennybiasiolli
Copy link
Contributor

Ref #1230

Manually instantiated WSGIRequest objects must be provided a file-like object for wsgi.input.

Copy link
Collaborator

@monkut monkut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a testcase to confirm that the create_wsgi_request response is a file-like object?

@dennybiasiolli
Copy link
Contributor Author

@monkut test case added 😉
Please note that I rebased this branch on top of the lint-fix branch (PR here: #1238), you can review the lint fixes there before merging this one

@monkut
Copy link
Collaborator

monkut commented May 3, 2023

Thanks for the hard work!
We'll try to get the 3.10 support release out ASAP, then squeeze out a point release shortly after, including this.

Copy link
Collaborator

@hellno hellno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

zappa/wsgi.py Show resolved Hide resolved
@coveralls
Copy link

coveralls commented May 15, 2023

Coverage Status

Coverage: 74.396% (-0.007%) from 74.403% when pulling 7ac0a37 on dennybiasiolli:django42 into 8502e92 on zappa:master.

@monkut monkut merged commit fb4e12d into zappa:master May 16, 2023
5 checks passed
@dennybiasiolli dennybiasiolli deleted the django42 branch May 16, 2023 06:23
Ian288 pushed a commit to tackle-io/Zappa that referenced this pull request Jul 11, 2023
Ref zappa#1230

- https://docs.djangoproject.com/en/4.2/releases/4.2/#miscellaneous
- https://wsgi.readthedocs.io/en/latest/definitions.html#envvar-wsgi.input

> Manually instantiated WSGIRequest objects must be provided
> a file-like object for wsgi.input.

Co-authored-by: monkut <shane.cousins@gmail.com>
BarNehemia added a commit to Lightricks/Zappa that referenced this pull request Aug 10, 2023
…zappa-0.57.0

* commit '0b1eab14ca39c3a3bfb4e915347e07495171dcba': (27 commits)
  updating workflow actions to remove deprecation warnings (zappa#1243)
  📝 CHANGELOG.md update for 0.57.0 (zappa#1246)
  fixing compatibility with Django 4.2 (zappa#1237)
  Update Readme with patreon and donors (zappa#1234)
  adding support for Python 3.10 (zappa#1231)
  Nose to pytest (zappa#1239)
  lint: updating code style with `make black` (zappa#1238)
  Alternative way to check if running in Docker (zappa#1204)
  📝 CHANGELOG.md update for 0.56.0 release (zappa#1187)
  Improve `get_best_match_zone()` to match by most matched components instead of by length of domain (zappa#1193)
  Bypass python version runtime check when code run in docker (zappa#1180)
  Be able to pass in a batch window when using batch size (zappa#1118)
  Correction to README. (zappa#1177)
  (zappa#908) Update BINARY_SUPPORT to use Content-Encoding to identify if data is binary (zappa#1155)
  Remove special check for Django<1.7, fix for zappa#1158  (zappa#1159)
  Resolve (zappa#410) Logs are missing query strings (zappa#1165)
  Handle spaces in x-forwared-for/remove six (zappa#1127) (zappa#1163)
  add feature (zappa#704) Check if args/kwargs are JSON Serializable while running locally (zappa#1154)
  docs: Add documentation for s3 event object key_filters (zappa#1169)
  Add feature pyenv virtualenv detecting .python-version file (zappa#1153)
  ...

# Conflicts:
#	zappa/cli.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants