add feature (#704) Check if args/kwargs are JSON Serializable while running locally #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- JSON unserializable content passed to asyncronous task during local develop will raise exception on purpose to allow developers to catch JSON unserializable errors during development. :white_check_mark: add `test_async_call_arg_not_json_seralizable` testcase :fire: remove unnecessary coding comment in `test_async.py`
monkut
changed the title
hellno
requested changes
Aug 8, 2022
🔧 add specific `UnserializableJsonError` exception for clarity
thommor
approved these changes
Aug 31, 2022
javulticat
reviewed
Sep 1, 2022
Co-authored-by: javulticat <31746850+javulticat@users.noreply.github.com>
…as per review comment
…n-serializable' into feature/issue-704-check-args-json-serializable
Ian288
pushed a commit
to tackle-io/Zappa
that referenced
this pull request
Jul 11, 2023
…ile running locally (zappa#1154) * ✨ add feature (zappa#705) - JSON unserializable content passed to asyncronous task during local develop will raise exception on purpose to allow developers to catch JSON unserializable errors during development. :white_check_mark: add `test_async_call_arg_not_json_seralizable` testcase :fire: remove unnecessary coding comment in `test_async.py` * :art: fix flake8 * :pencil: fix typo :wrench: add specific `UnserializableJsonError` exception for clarity * :white_check_mark: expand testcase to include custome exception, `UnserializableJsonError`. * :art: run isort/black * :fire: remove unnecessary assert Co-authored-by: javulticat <31746850+javulticat@users.noreply.github.com> * :recycle: simplify `validate_json_serializable()` to accept *args, **kwargs as per review comment * :fire: remove unnecessary import and use `object()` as unserializable_object sample. Co-authored-by: javulticat <31746850+javulticat@users.noreply.github.com>
BarNehemia
added a commit
to Lightricks/Zappa
that referenced
this pull request
Aug 10, 2023
…zappa-0.57.0 * commit '0b1eab14ca39c3a3bfb4e915347e07495171dcba': (27 commits) updating workflow actions to remove deprecation warnings (zappa#1243) 📝 CHANGELOG.md update for 0.57.0 (zappa#1246) fixing compatibility with Django 4.2 (zappa#1237) Update Readme with patreon and donors (zappa#1234) adding support for Python 3.10 (zappa#1231) Nose to pytest (zappa#1239) lint: updating code style with `make black` (zappa#1238) Alternative way to check if running in Docker (zappa#1204) 📝 CHANGELOG.md update for 0.56.0 release (zappa#1187) Improve `get_best_match_zone()` to match by most matched components instead of by length of domain (zappa#1193) Bypass python version runtime check when code run in docker (zappa#1180) Be able to pass in a batch window when using batch size (zappa#1118) Correction to README. (zappa#1177) (zappa#908) Update BINARY_SUPPORT to use Content-Encoding to identify if data is binary (zappa#1155) Remove special check for Django<1.7, fix for zappa#1158 (zappa#1159) Resolve (zappa#410) Logs are missing query strings (zappa#1165) Handle spaces in x-forwared-for/remove six (zappa#1127) (zappa#1163) add feature (zappa#704) Check if args/kwargs are JSON Serializable while running locally (zappa#1154) docs: Add documentation for s3 event object key_filters (zappa#1169) Add feature pyenv virtualenv detecting .python-version file (zappa#1153) ... # Conflicts: # zappa/cli.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running an async @task locally, the args and kwargs are passed as they are (even if they're not JSON Serializable).
This PR runs a
validate_json_seralizable()check on args/kwargs passed to the function when running locally, callingjson.dumps()on the arguments to allow related exceptions to propagate.This allow developers to identify asynchronous task related JSON serialization errors prior to deployment.
GitHub Issues
#704