Alternative way to check if running in Docker #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zappa master
Removed log file
monkut
requested changes
Dec 2, 2022
|
If the current check is unstable/unreliable, using a environment variable is much cleaner! |
monkut
requested changes
Dec 2, 2022
|
Can you pull in the CHANGLOG and version updates in this PR? Since this is an open issue, I want to get this fix released asap. |
monkut
requested changes
Dec 2, 2022
|
@gaborschulz can you check the lint results and run |
gaborschulz
force-pushed
the
zappa-1140
branch
from
d82fa03
to
10a40a8
Compare
monkut
requested changes
Dec 3, 2022
monkut
approved these changes
Dec 3, 2022
goya813
approved these changes
Dec 3, 2022
Ian288
pushed a commit
to tackle-io/Zappa
that referenced
this pull request
Jul 11, 2023
* Update setup.py * Update __init__.py * 🐛 fix FileNotFoundError in running_in_docker (zappa#1201) * Remove version constraints * Changed the way Docker is determined * Reference to ticket 1140 * Added documentation for ZAPPA_RUNNING_IN_DOCKER flag * Fixed indentation * Removed log file * Added strtobool and re-added MINIMUM_SUPPORTED_MIINOR_VERSION * updated version * Added zappa#1201 to CHANGELOG.md, reformatted code * Reformatted by black due to line length * Removed unnecessary comment Co-authored-by: monkut <shane.cousins@gmail.com>
BarNehemia
added a commit
to Lightricks/Zappa
that referenced
this pull request
Aug 10, 2023
…zappa-0.57.0 * commit '0b1eab14ca39c3a3bfb4e915347e07495171dcba': (27 commits) updating workflow actions to remove deprecation warnings (zappa#1243) 📝 CHANGELOG.md update for 0.57.0 (zappa#1246) fixing compatibility with Django 4.2 (zappa#1237) Update Readme with patreon and donors (zappa#1234) adding support for Python 3.10 (zappa#1231) Nose to pytest (zappa#1239) lint: updating code style with `make black` (zappa#1238) Alternative way to check if running in Docker (zappa#1204) 📝 CHANGELOG.md update for 0.56.0 release (zappa#1187) Improve `get_best_match_zone()` to match by most matched components instead of by length of domain (zappa#1193) Bypass python version runtime check when code run in docker (zappa#1180) Be able to pass in a batch window when using batch size (zappa#1118) Correction to README. (zappa#1177) (zappa#908) Update BINARY_SUPPORT to use Content-Encoding to identify if data is binary (zappa#1155) Remove special check for Django<1.7, fix for zappa#1158 (zappa#1159) Resolve (zappa#410) Logs are missing query strings (zappa#1165) Handle spaces in x-forwared-for/remove six (zappa#1127) (zappa#1163) add feature (zappa#704) Check if args/kwargs are JSON Serializable while running locally (zappa#1154) docs: Add documentation for s3 event object key_filters (zappa#1169) Add feature pyenv virtualenv detecting .python-version file (zappa#1153) ... # Conflicts: # zappa/cli.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
running_in_dockerfunction can lead to unpredictable results, in certain cases it does not recognize that it's running inside docker and leads to the version check being in place. This produces errors in build pipelines.GitHub Issues
#1140
#1201