Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nose to pytest #1239

Merged
merged 11 commits into from
May 4, 2023
Merged

Nose to pytest #1239

merged 11 commits into from
May 4, 2023

Conversation

dennybiasiolli
Copy link
Contributor

@dennybiasiolli dennybiasiolli commented May 1, 2023

Migrating test suite from the old nose to the new pytest, keeping coverage results (aggregated) and duration display.

Inspired by @monkut in #1231 (comment)

This PR goes after this one: #1238
in order to preserve style formatting there and use it from now on.

#1146

with

```
pipenv install --dev pytest
pipenv install --dev pytest-cov
```
when running tests there was this warning:

```
DeprecationWarning: 'werkzeug.urls.url_unquote' is deprecated and will be
removed in Werkzeug 2.4. Use 'urllib.parse.unquote' instead.
```
```
DeprecationWarning: Please use assertRegex instead of assertRegexpMatches
```
@monkut
Copy link
Collaborator

monkut commented May 3, 2023

thanks for the hard work!
Looks like isort/black needs to be run.

@dennybiasiolli
Copy link
Contributor Author

dennybiasiolli commented May 3, 2023

@monkut need to merge this one first #1238 so we can fix the linting before everything else 😉

```
DeprecationWarning: Please use assertRaisesRegex instead of assertRaisesRegexp
```
```
DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
```
```
DeprecationWarning: Please use assertEqual instead of assertEquals
```
keeping coverage results (aggregated) and duration display
Copy link
Collaborator

@hellno hellno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing effort, thank you! 🙌🏽🙌🏽 LGTM

@coveralls
Copy link

Coverage Status

Coverage: 74.375% (-0.2%) from 74.547% when pulling 0afc989 on dennybiasiolli:nose-to-pytest into 73ee393 on zappa:master.

@monkut monkut merged commit 7a5e153 into zappa:master May 4, 2023
4 checks passed
@dennybiasiolli dennybiasiolli deleted the nose-to-pytest branch May 4, 2023 09:23
Ian288 pushed a commit to tackle-io/Zappa that referenced this pull request Jul 11, 2023
* lint: updating code style with `make black`

* adding pytest related package

with

```
pipenv install --dev pytest
pipenv install --dev pytest-cov
```

* wsgi: fixing DeprecationWarning

when running tests there was this warning:

```
DeprecationWarning: 'werkzeug.urls.url_unquote' is deprecated and will be
removed in Werkzeug 2.4. Use 'urllib.parse.unquote' instead.
```

* tests: using `redirect_stdout` to redirect stdout to a readable source

* tests_utilities: fixing deprecation warning

```
DeprecationWarning: Please use assertRegex instead of assertRegexpMatches
```

* tests_utilities: removing try/finally in test_certify_sanity_checks

* tests_placebo: : fixing deprecation warning

```
DeprecationWarning: Please use assertRaisesRegex instead of assertRaisesRegexp
```

* zappa(core): fixing deprecation warning

```
DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
```

* tests_docs: fixing deprecation warning

```
DeprecationWarning: Please use assertEqual instead of assertEquals
```

* tests: moving from nose to pytest

keeping coverage results (aggregated) and duration display

* tests: removing and uninstalling all nose references
BarNehemia added a commit to Lightricks/Zappa that referenced this pull request Aug 10, 2023
…zappa-0.57.0

* commit '0b1eab14ca39c3a3bfb4e915347e07495171dcba': (27 commits)
  updating workflow actions to remove deprecation warnings (zappa#1243)
  📝 CHANGELOG.md update for 0.57.0 (zappa#1246)
  fixing compatibility with Django 4.2 (zappa#1237)
  Update Readme with patreon and donors (zappa#1234)
  adding support for Python 3.10 (zappa#1231)
  Nose to pytest (zappa#1239)
  lint: updating code style with `make black` (zappa#1238)
  Alternative way to check if running in Docker (zappa#1204)
  📝 CHANGELOG.md update for 0.56.0 release (zappa#1187)
  Improve `get_best_match_zone()` to match by most matched components instead of by length of domain (zappa#1193)
  Bypass python version runtime check when code run in docker (zappa#1180)
  Be able to pass in a batch window when using batch size (zappa#1118)
  Correction to README. (zappa#1177)
  (zappa#908) Update BINARY_SUPPORT to use Content-Encoding to identify if data is binary (zappa#1155)
  Remove special check for Django<1.7, fix for zappa#1158  (zappa#1159)
  Resolve (zappa#410) Logs are missing query strings (zappa#1165)
  Handle spaces in x-forwared-for/remove six (zappa#1127) (zappa#1163)
  add feature (zappa#704) Check if args/kwargs are JSON Serializable while running locally (zappa#1154)
  docs: Add documentation for s3 event object key_filters (zappa#1169)
  Add feature pyenv virtualenv detecting .python-version file (zappa#1153)
  ...

# Conflicts:
#	zappa/cli.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants