-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support all types dataSource #87
Conversation
Hello. What you think about this pull-request? |
Hi @stepanovD, We are out this week. Would look into it once we are back |
Hi. Are you planning to add this changes in future releases? |
|
||
/** | ||
* Generate datasource for druid query. See documentation | ||
* <a href="http://druid.io/docs/latest/querying/datasource.html"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
No comments 👍
Thank you. |
Hey @stepanovD Sorry for the delay. Yes are definitely planning to add these changes in future release. As you yourself said, these are the breaking changes so we can plan to add these in 3.0 release. But there are few patches that we are planning to release in 2.x and then we can release this patch. |
Reformat code is done! Copyright already added. |
Hello. This pull request includes support for all types of datasource (table, union, query). It's nice feature for support subquery as datasource. I understand, this change breaking backward compatibility, but it's very important feature. May be adding this change in 3.0 release is better.