Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support all types dataSource #87

Merged
merged 4 commits into from
Feb 16, 2020
Merged

Conversation

stepanovD
Copy link

Hello. This pull request includes support for all types of datasource (table, union, query). It's nice feature for support subquery as datasource. I understand, this change breaking backward compatibility, but it's very important feature. May be adding this change in 3.0 release is better.

@stepanovD
Copy link
Author

Hello. What you think about this pull-request?

@GG-Zapr
Copy link
Member

GG-Zapr commented Mar 1, 2019

Hi @stepanovD, We are out this week. Would look into it once we are back

@stepanovD
Copy link
Author

Hi. Are you planning to add this changes in future releases?


/**
* Generate datasource for druid query. See documentation
* <a href="http://druid.io/docs/latest/querying/datasource.html">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@abhi-zapr
Copy link
Contributor

abhi-zapr commented Jul 27, 2019

No comments 👍
But implement this few points :

Thank you.

@abhi-zapr
Copy link
Contributor

Hi. Are you planning to add this changes in future releases?

Hey @stepanovD

Sorry for the delay. Yes are definitely planning to add these changes in future release. As you yourself said, these are the breaking changes so we can plan to add these in 3.0 release. But there are few patches that we are planning to release in 2.x and then we can release this patch.

@stepanovD
Copy link
Author

  • Reformat code if indentation is not equal everywhere. If you are using IntelliJ to code, you can use this style guide.

Reformat code is done! Copyright already added.

@abhi-zapr abhi-zapr added this to the v3.0 milestone Aug 10, 2019
@abhi-zapr abhi-zapr added breaking change patch is implementing new features but is breaking backward compatibility enhancement labels Aug 10, 2019
@abhi-zapr abhi-zapr merged commit 147f270 into zapr-oss:develop Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change patch is implementing new features but is breaking backward compatibility enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants