Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented a new ZestAssignment which can filter the parsed DOM by e… #117

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Implemented a new ZestAssignment which can filter the parsed DOM by e… #117

merged 1 commit into from
Sep 18, 2017

Conversation

denniskniep
Copy link
Member

…lement or attributes and select the content of an element or the value of an attribute

@denniskniep
Copy link
Member Author

The use case for this occurred in ZAP. I would like to get the value of the action attribute of the second form element.
Beyond this requirement I added some further useful ways of filtering and selecting elements and attributes in the DOM.

@denniskniep denniskniep force-pushed the feature/form_assignments branch 3 times, most recently from 50ed09c to a4c201f Compare August 15, 2017 20:47
@denniskniep denniskniep force-pushed the feature/form_assignments branch 2 times, most recently from c0feda9 to dd481b0 Compare August 15, 2017 21:37
thc202
thc202 reviewed Sep 14, 2017
View reviewed changes
Copy link
Member

@thc202 thc202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a de/serialisation test (like the one in ZestAssignStringUnitTest), and check that the assign still works?

src/main/java/org/mozilla/zest/core/v1/ZestAssignFromElement.java Outdated Show resolved Hide resolved
src/main/java/org/mozilla/zest/core/v1/ZestAssignFromElement.java Outdated Show resolved Hide resolved
src/main/java/org/mozilla/zest/core/v1/ZestAssignFromElement.java Outdated Show resolved Hide resolved
@denniskniep
Copy link
Member Author

@thc202: pushed your improvements
but tested only with wrong regex. What is a possible wrong flag? Test is always green?!

@thc202
Copy link
Member

thc202 commented Sep 15, 2017

Sorry, I was mislead by the JavaDoc of Pattern.compile which mentions that an exception can be thrown if the flags are wrong but looking at the implementation there's no actual check.

@denniskniep
Implemented a new ZestAssignment which can filter the parsed DOM by e…
95493c3 
…lement or attributes and select the content of an element or the value of an attribute
@thc202
Copy link
Member

thc202 commented Sep 18, 2017

Thank you!

@psiinon psiinon merged commit a4833c4 into zaproxy:develop Sep 18, 2017
@thc202 thc202 mentioned this pull request Apr 13, 2018
Merged
@thc202 thc202 added this to the 0.14.0 milestone Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psiinon psiinon psiinon approved these changes

@thc202 thc202 thc202 approved these changes

Assignees
No one assigned
Labels
enhancement
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@denniskniep @thc202 @psiinon