Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up Java code #201

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Tidy up Java code #201

merged 1 commit into from
Nov 1, 2019

Conversation

thc202
Copy link
Member

@thc202 thc202 commented Nov 1, 2019

Address SonarLint issues:

  • Simplify boolean checks in and/or Zest expressions.
  • Remove:
    • Redundant type arguments, method modifiers in interfaces, and
      JavaDoc in test methods;
    • Unnecessary semicolon and array instantiations (varargs);
    • Declaration of runtime exceptions and of exceptions not actually
      thrown;
  • Replace for loop with Collections.addAll;
  • Use same catch block.

Address SonarLint issues:
 - Simplify boolean checks in and/or Zest expressions.
 - Remove:
  - Redundant type arguments, method modifiers in interfaces, and
  JavaDoc in test methods;
  - Unnecessary semicolon and array instantiations (varargs);
  - Declaration of runtime exceptions and of exceptions not actually
  thrown;
 - Replace for loop with `Collections.addAll`;
 - Use same catch block.

Signed-off-by: thc202 <thc202@gmail.com>
@psiinon psiinon merged commit f9405e6 into zaproxy:develop Nov 1, 2019
@thc202 thc202 deleted the tidyup-java branch November 4, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants