added mouseover, resize and scroll #244

aryangupta701 · 2023-03-08T17:46:03Z

Added mouseover, resize and scroll methods to handle hovering, resizing window and scrolling.

aryangupta701 · 2023-03-08T17:52:10Z

@psiinon Please guide me how can I test the behaviour of the newly added methods? I am not sure weather this will work or not.

psiinon · 2023-03-08T17:56:34Z

Sure :)
The way I would do it is to:

create a suitable test page
write a simple Zest script in ZAP which interacts with it in a basic way
run it in ZAP (to make sure it works)
save the script
run it from the command line (this is to make sure everything is still ok)
add one of the new statements which will do something detectable
run the script again from the cmdline - you should see the effect
repeat for the other statements

aryangupta701 · 2023-03-08T17:59:00Z

okay thank you.

thc202 · 2023-03-08T17:59:10Z

Also worth looking at the codebase (e.g. ZestClientScreenshotUnitTest) to add unit tests.

aryangupta701 · 2023-03-08T18:02:32Z

how can I run the script from the command line ?

psiinon · 2023-03-08T18:05:16Z

Theres https://github.com/zaproxy/zest/wiki/Commandline but I havnt tried it in a while - give it a go and let us know if you have any problems...

aryangupta701 · 2023-03-08T20:08:02Z

I have tested it manually and it is working as expected. I am not able to understand what kind of unit test will it need to be written. Please guide me through it. I have seen ZestClientScreenshotUnitTest but still not sure about what kind of tests are needed.

thc202 · 2023-03-08T20:31:41Z

The tests you did manually do them automatically :) If that's not possible verify that at least the expected classes are called, other behaviour than the invoke itself should be tested as well.

Edit: To be clear I do think that all 3 statements being added can be tested automatically.

src/main/java/org/zaproxy/zest/core/v1/ZestClientElementMouseOut.java

src/main/java/org/zaproxy/zest/core/v1/ZestClientElementScroll.java

aryangupta701 · 2023-03-09T05:52:11Z

Thankyou @thc202

aryangupta701 · 2023-03-09T10:52:45Z

@thc202 I have written test for scrolling as of now. Please check if I went into the right direction, then I will write for others as well.

psiinon · 2023-03-20T17:25:00Z

@aryangupta701 - looking good so far, let us know when its ready to review again.

aryangupta701 · 2023-03-20T17:29:01Z

okay sure.

aryangupta701 · 2023-03-25T17:36:57Z

I do think that these methods along with already present methods will be sufficient to handle all the user interactions. If you think I am missing something please tell me.

src/main/java/org/zaproxy/zest/core/v1/ZestClientWindowResize.java

CHANGELOG.md

thc202 · 2023-03-30T13:46:49Z

#244 (comment)

IMO a scroll to statement would be easier to use in most cases (though the scroll element might still be useful/needed in some cases).

#244 (comment)

This one was not yet addressed, the invoke methods are not being tested.

thc202 · 2023-04-03T20:14:08Z

You don't need to mock the Actions, you have both the WebDriver and the WebElement to verify the interactions. If that's too much work you can run the actual statement (e.g. ZestClientLaunchUnitTest.testHtmlUnitLaunch()) and verify the outcome.

aryangupta701 · 2023-04-04T07:59:35Z

okay thanks. Will I need to create a test website to test mouseover statement?

thc202 · 2023-04-04T08:36:54Z

Yes, you can serve static data like done in the test mentioned earlier (e.g. check before method and ServerBasedTest).

aryangupta701 · 2023-04-04T08:40:27Z

okay.

aryangupta701 · 2023-04-24T17:10:05Z

@thc202 Could you please review and tell me if anything needs to be changed?

kingthorin

LGTM just a question about license/header for the team

kingthorin · 2023-06-21T15:34:02Z

src/main/java/org/zaproxy/zest/core/v1/ZestClientElementMouseOver.java

+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/. */


@psiinon @thc202 should we be using a different header now?

I'm fine either way.

I guess thats a separate discussion - I dont mind too much either way either 😉

src/test/java/org/zaproxy/zest/test/v1/ZestClientElementMouseOverUnitTest.java

src/test/java/org/zaproxy/zest/test/v1/ZestClientWindowResizeUnitTest.java

Signed-off-by: aryangupta701 <garyan447@gmail.com>

into add-new-commands

thc202 · 2023-06-23T21:46:58Z

Thank you!

aryangupta701 force-pushed the add-new-commands branch from ee25439 to 049ae49 Compare March 8, 2023 17:49

aryangupta701 force-pushed the add-new-commands branch from f60c9df to 93135bf Compare March 8, 2023 19:45

thc202 reviewed Mar 8, 2023

View reviewed changes

aryangupta701 changed the title ~~added mouseout,mouseover and scroll~~ added mouseover and scroll Mar 16, 2023

aryangupta701 force-pushed the add-new-commands branch 5 times, most recently from dc7058d to 6aad95a Compare March 16, 2023 16:10

aryangupta701 changed the title ~~added mouseover and scroll~~ added mouseover, resize and scroll Mar 18, 2023

aryangupta701 force-pushed the add-new-commands branch 2 times, most recently from cc40007 to 2688696 Compare March 18, 2023 18:31

aryangupta701 requested a review from thc202 March 20, 2023 16:51

aryangupta701 force-pushed the add-new-commands branch from a7933d3 to df5822b Compare March 21, 2023 06:08

aryangupta701 force-pushed the add-new-commands branch from df5822b to 912432e Compare March 29, 2023 10:15

thc202 reviewed Mar 30, 2023

View reviewed changes

src/main/java/org/zaproxy/zest/core/v1/ZestClientWindowResize.java Outdated Show resolved Hide resolved

src/main/java/org/zaproxy/zest/core/v1/ZestClientWindowResize.java Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

aryangupta701 force-pushed the add-new-commands branch from 21b1e48 to 953bdbb Compare April 1, 2023 17:29

aryangupta701 force-pushed the add-new-commands branch 2 times, most recently from 7d749ad to 7b618fb Compare April 5, 2023 05:48

aryangupta701 requested a review from thc202 April 5, 2023 12:16

psiinon approved these changes Jun 21, 2023

View reviewed changes

kingthorin reviewed Jun 21, 2023

View reviewed changes

thc202 reviewed Jun 22, 2023

View reviewed changes

src/test/java/org/zaproxy/zest/test/v1/ZestClientElementMouseOverUnitTest.java Outdated Show resolved Hide resolved

src/test/java/org/zaproxy/zest/test/v1/ZestClientWindowResizeUnitTest.java Outdated Show resolved Hide resolved

added tests to check invoke

4ce6e31

Signed-off-by: aryangupta701 <garyan447@gmail.com>

aryangupta701 force-pushed the add-new-commands branch from 410c808 to 4ce6e31 Compare June 23, 2023 16:13

aryangupta701 added 11 commits June 23, 2023 21:49

added mouseout,mouseover and scroll

c7aac28

Signed-off-by: aryangupta701 <garyan447@gmail.com>

spotlessApply

ae69307

Signed-off-by: aryangupta701 <garyan447@gmail.com>

actions working fine

5b55cf1

Signed-off-by: aryangupta701 <garyan447@gmail.com>

spotlessApply

5586c75

Signed-off-by: aryangupta701 <garyan447@gmail.com>

removed unwanted code

a77fc64

Signed-off-by: aryangupta701 <garyan447@gmail.com>

added tests

7e205ca

Signed-off-by: aryangupta701 <garyan447@gmail.com>

minor change in test

b2ef646

Signed-off-by: aryangupta701 <garyan447@gmail.com>

added tests

8fe1363

Signed-off-by: aryangupta701 <garyan447@gmail.com>

added test for resize

fafb614

Signed-off-by: aryangupta701 <garyan447@gmail.com>

added tests to check invoke

a1c1869

Signed-off-by: aryangupta701 <garyan447@gmail.com>

Merge branch 'add-new-commands' of https://github.com/aryangupta701/zest

63c8278

into add-new-commands

aryangupta701 force-pushed the add-new-commands branch from 73230ec to 63c8278 Compare June 23, 2023 21:14

thc202 enabled auto-merge (squash) June 23, 2023 21:46

thc202 approved these changes Jun 23, 2023

View reviewed changes

thc202 merged commit 7667e34 into zaproxy:main Jun 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added mouseover, resize and scroll #244

added mouseover, resize and scroll #244

aryangupta701 commented Mar 8, 2023 •

edited by thc202

Loading

aryangupta701 commented Mar 8, 2023

psiinon commented Mar 8, 2023

aryangupta701 commented Mar 8, 2023

thc202 commented Mar 8, 2023

aryangupta701 commented Mar 8, 2023

psiinon commented Mar 8, 2023

aryangupta701 commented Mar 8, 2023 •

edited

Loading

thc202 commented Mar 8, 2023 •

edited

Loading

aryangupta701 commented Mar 9, 2023

aryangupta701 commented Mar 9, 2023

psiinon commented Mar 20, 2023

aryangupta701 commented Mar 20, 2023

aryangupta701 commented Mar 25, 2023

thc202 commented Mar 30, 2023 •

edited

Loading

thc202 commented Apr 3, 2023 •

edited

Loading

aryangupta701 commented Apr 4, 2023

thc202 commented Apr 4, 2023

aryangupta701 commented Apr 4, 2023

aryangupta701 commented Apr 24, 2023 •

edited

Loading

kingthorin left a comment

kingthorin Jun 21, 2023

thc202 Jun 22, 2023

psiinon Jun 22, 2023

thc202 commented Jun 23, 2023

added mouseover, resize and scroll #244

added mouseover, resize and scroll #244

Conversation

aryangupta701 commented Mar 8, 2023 • edited by thc202 Loading

aryangupta701 commented Mar 8, 2023

psiinon commented Mar 8, 2023

aryangupta701 commented Mar 8, 2023

thc202 commented Mar 8, 2023

aryangupta701 commented Mar 8, 2023

psiinon commented Mar 8, 2023

aryangupta701 commented Mar 8, 2023 • edited Loading

thc202 commented Mar 8, 2023 • edited Loading

aryangupta701 commented Mar 9, 2023

aryangupta701 commented Mar 9, 2023

psiinon commented Mar 20, 2023

aryangupta701 commented Mar 20, 2023

aryangupta701 commented Mar 25, 2023

thc202 commented Mar 30, 2023 • edited Loading

thc202 commented Apr 3, 2023 • edited Loading

aryangupta701 commented Apr 4, 2023

thc202 commented Apr 4, 2023

aryangupta701 commented Apr 4, 2023

aryangupta701 commented Apr 24, 2023 • edited Loading

kingthorin left a comment

Choose a reason for hiding this comment

kingthorin Jun 21, 2023

Choose a reason for hiding this comment

thc202 Jun 22, 2023

Choose a reason for hiding this comment

psiinon Jun 22, 2023

Choose a reason for hiding this comment

thc202 commented Jun 23, 2023

aryangupta701 commented Mar 8, 2023 •

edited by thc202

Loading

aryangupta701 commented Mar 8, 2023 •

edited

Loading

thc202 commented Mar 8, 2023 •

edited

Loading

thc202 commented Mar 30, 2023 •

edited

Loading

thc202 commented Apr 3, 2023 •

edited

Loading

aryangupta701 commented Apr 24, 2023 •

edited

Loading