Settings Ui Page 1 and 2 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full convert of page 1 & 2 to ui file, using better layout management (using formlayout, hbox & vbox).
I don't know these scripts 😃 |
|
Thanks! All Settings Ui changes should be done in |
|
Understood. |
zaps166
pushed a commit
that referenced
this pull request
Jul 3, 2016
Full convert of page 1 & 2 to ui file. Using better layout management (using formlayout, hbox & vbox).
Merged
zaps166
pushed a commit
that referenced
this pull request
Jul 7, 2016
Full convert of page 1 & 2 to ui file. Using better layout management (using formlayout, hbox & vbox).
zaps166
pushed a commit
that referenced
this pull request
Jul 12, 2016
zaps166
pushed a commit
that referenced
this pull request
Jul 15, 2016
zaps166
pushed a commit
that referenced
this pull request
Jul 15, 2016
zaps166
pushed a commit
that referenced
this pull request
Jul 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retarget of #35.
Fixed all the comments.
Also, about the styling problem. I don't think this problem won't happen again in future contributions. Maybe we should add some kind of style fixer script (for example using
astyleorclang-format).