Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move settings UI into QtDesigner #13

Closed
zaps166 opened this issue May 30, 2016 · 4 comments
Closed

Move settings UI into QtDesigner #13

zaps166 opened this issue May 30, 2016 · 4 comments

Comments

@zaps166
Copy link
Owner

zaps166 commented May 30, 2016

Modifying the settings window is very inconvenient in pure C++, so move settings UI into *.ui files.

@arthurzam
Copy link
Contributor

I would like to work on this task. But for this I have some questions:

  1. In my opinion, for easier managing of the various object with names, it is better to create a ui file per every tab (or page as it is called in the code). To every ui file an appropriate class file will be created for managing the information associated with it (making it much more grouped).
  2. *.ui files don't handle something like ifdef. I can fix this problem by setting the hidden flag when the ifdef happens.
  3. ui files don't support partial translatability. For example you have lines like (tr("Style") + ": "). Should I make it just as "Style: " or set the text in C++ code?
  4. For grouping of files, should we move all future files of Settings From to specific folder named "settings"?

@zaps166
Copy link
Owner Author

zaps166 commented Jun 30, 2016

I'll think about this later, but:

  • I want to do one folder with all *.ui files,
  • hidden flag is not the same - it can create visible small space in grid layout.

One form with all tabs or tabs in different UIs and merge it in C++ (C++ main settings window) - I don't know which will be better.

@zaps166
Copy link
Owner Author

zaps166 commented Jul 15, 2016

Done: 2dc9b61 (#38, #39, #40), 961e533, dc3d73f

@arthurzam Thanks!!!

@zaps166 zaps166 closed this as completed Jul 15, 2016
@arthurzam
Copy link
Contributor

@zaps166 Was happy to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants