Fix “Your test suite must contain at least one test” problem when it/test is used without describe
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`/`test` is used without `describe`
If we use `test()` or `it()` without putting it in `describe` block,
when this reporter is active, the test will fail with confusing error:
Your test suite must contain at least one test
Inspecting further,
I found that `allure.startCase()` will error out if `allure.startSuite` is not called before.
To fix this, I changed the notion of `suite` and `case`.
Now, 1 test file = 1 suite, regardless of `describe` blocks.
The title of each `describe` block is prepended to each case.
This matches the behavior of `jest-junit`.
|
Sorry, it's not expected behaviour to me. |
|
@zaqqaz Then what is the expected behavior for when a test calls In my opinion, maybe an error saying “When using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use
test()orit()without putting it indescribeblock, when this reporter is active, the test will fail with this confusing error message:Inspecting further, I found that
allure.startCase()will error out ifallure.startSuitehas not been called before.To fix this, I changed the notion of
suiteandcase. Now, 1 test file = 1 suite, regardless ofdescribeblocks. The title of eachdescribeblock is prepended to each case. This matches the behavior ofjest-junit.