-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to deploy remote packages #143
Conversation
/test all |
/test all |
The PR looks good, though we might want to breakup that Deploy() function a little, it's getting heft. However I do have concerns with this idea overall until we have more SBOM components. If we aren't validating a signature or even SHA hash then we have no way to vet the quality of this content or that it should be trusted. I'm not certain what the right answer is, but I think we should discuss that concern a little before merging. CC @RothAndrew @mikhailswift |
I do find value in this from an ease-of-use perspective, though I definitely do see the security implications. We could potentially require the user to add a Example: # Won't work
zarf package deploy https://example.com/some-package.tar.zst
ERROR: --shasum or --insecure required to proceed
# The right way
zarf package deploy https://example.com/some-package.tar.zst --shasum aec070645fe53ee3b3763059376134f058cc337247c978add178b6ccdfb0019f
# The insecure way
zarf package deploy https://example.com/some-package.tar.zst --insecure We could also require |
I like that format, think it should be part of this PR before merge @YrrepNoj |
1238d64
to
239cb0c
Compare
/test all |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Only comment on the slice constant problem. We could make it private and use a getter with a by value return, I think that would get after the immutability quality of a constant.
/test all |
* Add ability to deploy remote packages * Rename 'packagePath' variable in deploy code to better represent value * Update package deploy help message to describe URL usage * Add shasum check for remote package deployments * Add e2e test for deploying remote packages * Add initializer function for ValidFileExtensions variable Signed-off-by: Jeff McCoy <code@jeffm.us>
* Add ability to deploy remote packages * Rename 'packagePath' variable in deploy code to better represent value * Update package deploy help message to describe URL usage * Add shasum check for remote package deployments * Add e2e test for deploying remote packages * Add initializer function for ValidFileExtensions variable Signed-off-by: Jeff McCoy <code@jeffm.us>
Adding the ability for Zarf to deploy remote packages. This checks if the deployPath given is a URL with a file extension we recognize. If the path is a valid package it gets downloaded to /temp and processed.
This also renames
packageName
topackagePath
to try to show that the variable is more than just a name and could either be a full path to a file or even a URL to some online resource.Potential Issues To Add After Merge: