Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: packager inspect command #2990

Merged
merged 25 commits into from
Sep 24, 2024
Merged

refactor: packager inspect command #2990

merged 25 commits into from
Sep 24, 2024

Conversation

schristoff
Copy link
Contributor

@schristoff schristoff commented Sep 11, 2024 •
edited
Loading

relates to #2969

@netlify Netlify
Copy link

netlify bot commented Sep 11, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 17ce037
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66f2dbf240198e00083ce7de

@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 3.75000% with 77 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/inspect.go 0.00% 56 Missing ⚠️
src/cmd/package.go 0.00% 20 Missing ⚠️
src/internal/packager2/remove.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/packager2/load.go 56.00% <100.00%> (+0.96%) ⬆️
src/internal/packager2/remove.go 0.00% <0.00%> (ø)
src/cmd/package.go 0.00% <0.00%> (ø)
src/internal/packager2/inspect.go 0.00% <0.00%> (ø)

@schristoff schristoff marked this pull request as ready for review September 11, 2024 21:58
@schristoff schristoff requested review from a team as code owners September 11, 2024 21:58
@schristoff schristoff changed the title refactor package/injector refactor: packager2 inspect Sep 11, 2024
@phillebaba phillebaba changed the title refactor: packager2 inspect refactor: packager inspect command Sep 11, 2024
@schristoff
refactor package/injector
45164aa 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
revert Makefile, remove unhelpful todo
51d3d52 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
refactor function signatures
fab98f2 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
linterlinterlinterlinter
fee956b 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
go lint urself
acd686f 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
packagepackagepackage
170fc97 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
spdx license
a55e52f 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
utilizeLoad
fc4fe01 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
weird why did these change
b66246c 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
revert shasum
0d7a93b 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
little l delete test filter empty
822afeb 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
stop checking log output
7e6f780 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
not skip
081b38f 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
new feature
b0a7d83 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
be more insecure
14b6153 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
readd test to fail, minor fixes
bc06308 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
phillebaba
phillebaba reviewed Sep 23, 2024
View reviewed changes
src/internal/packager2/inspect.go Outdated Show resolved Hide resolved
src/test/e2e/11_oci_pull_inspect_test.go Outdated Show resolved Hide resolved
src/test/e2e/31_checksum_and_signature_test.go Outdated Show resolved Hide resolved
@schristoff
insecure to skip validaion signature
8282473 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
Merge branch 'main' into schristoff_pkgpkgv2
77e2eef
@schristoff
Merge branch 'main' into schristoff_pkgpkgv2
813e18d
@schristoff
use load, skip valid
0ce03fd 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
test w/ destroyed load
c502bfa 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
it wasnt the destroyed load?
0fbab7d 
This reverts commit c502bfa.
@schristoff
pass publickeypath everywhere
6039d7c 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff
Merge branch 'main' into schristoff_pkgpkgv2
607297a
@schristoff
remove identifyAndFallbackToClusterSource
17ce037 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
phillebaba
phillebaba approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@phillebaba phillebaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@phillebaba phillebaba added this pull request to the merge queue Sep 24, 2024
Merged via the queue into zarf-dev:main with commit 5d4fc4b Sep 24, 2024
27 checks passed
@schristoff schristoff deleted the schristoff_pkgpkgv2 branch September 24, 2024 22:26
@renovate renovate bot mentioned this pull request Oct 12, 2024
Open
1 task
ittacco pushed a commit to ittacco/zarf that referenced this pull request Nov 9, 2024
@schristoff @ittacco
refactor: packager inspect command (zarf-dev#2990)
e4363ac 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: ittacco <lorenzo.tacconi1967@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillebaba phillebaba phillebaba approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schristoff @phillebaba