Fix for deprecation warning in rails 7 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for catching this and for the PR! It seems like this change will break backwards compatibility with versions of Rails prior to v7. Unless you believe otherwise, perhaps a conditional could be added to maintain that compatibility? |
|
You are absolutely right! This is my first attempt at a contribution to an open source project, and I jumped the gun. |
|
I have added a conditional, and tested with both Rails versions 6.1.6.1 and 7.0.3. It appears to work properly with both versions. Hopefully, I have got it right this time. |
|
Looks good! Honored that you'd make your first opensource contribution to this project. Thanks so much! |
|
Fantastic. And thank you for this wonderfully useful Gem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7 gives the following deprecation warning:
DEPRECATION WARNING:
ActiveRecord::Base.partial_writes=is deprecated and will be removed in Rails 7.1. Usepartial_updates=andpartial_inserts=instead. (called from class:SelfCleaningSession at /Users/david/RubymineProjects/limited_sessions/lib/limited_sessions/self_cleaning_session.rb:5)The pull request clears the warning.