Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN release 2.3.1 fails to build on clang MacOS X #3

Closed
jefferis opened this issue Dec 29, 2015 · 3 comments
Closed

CRAN release 2.3.1 fails to build on clang MacOS X #3

jefferis opened this issue Dec 29, 2015 · 3 comments

Comments

@jefferis
Copy link
Contributor

Hi Stefan,

It looks like the latest build of Rvcg fails to build with clang on the R build server:

https://cran.r-project.org/web/checks/check_results_Rvcg.html

This mainly affects macosx binaries:

https://www.r-project.org/nosvn/R.check/r-release-osx-x86_64-mavericks/Rvcg-00check.html

The error looks to me like it is related to this one

libgamera/GAMERA#12

which I guess would make it a missing include. But I see you already added an isnan patch here:

zarquon42b/Rvcg@e22193c

So it may be that you just need to test for clang as well as gcc (as commented here zarquon42b/Rvcg@e22193c#commitcomment-15195841).

@zarquon42b
Copy link
Owner

Hi Greg,
I fixed it here (master is already at next vcglib snapshot and c++11 only):
zarquon42b/Rvcg@7c219ca
I will release it the next days. The issue is an issue of proper
namespace injection of isnan.

Best
Stefan

On 29/12/15 21:44, Gregory Jefferis wrote:

Hi Stefan,

It looks like the latest build of Rvcg fails to build with clang on
the R build server:

https://cran.r-project.org/web/checks/check_results_Rvcg.html

This mainly affects macosx binaries:

https://www.r-project.org/nosvn/R.check/r-release-osx-x86_64-mavericks/Rvcg-00check.html

The error looks to me like it is related to this one

libgamera/GAMERA#12 libgamera/GAMERA#12

which I guess would make it a missing include. But I see you already
added an isnan patch here:

zarquon42b/Rvcg@e22193c
zarquon42b/Rvcg@e22193c

So it may be that you just need to test for clang as well as gcc (as
commented here zarquon42b/Rvcg@e22193c#commitcomment-15195841
zarquon42b/Rvcg@e22193c#commitcomment-15195841).


Reply to this email directly or view it on GitHub
#3.

@jefferis
Copy link
Contributor Author

OK – sorry I missed that. Thanks! Best, Greg.

@zarquon42b
Copy link
Owner

Released and seemingly all OK now: https://cran.r-project.org/web/checks/check_results_Rvcg.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants