Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aggrid.get_client_data returns unsorted data #3581

Closed
JeppeKlitgaard opened this issue Aug 23, 2024 · 0 comments · Fixed by #3582
Closed

aggrid.get_client_data returns unsorted data #3581

JeppeKlitgaard opened this issue Aug 23, 2024 · 0 comments · Fixed by #3582
Labels
enhancement New feature or request
Milestone
1.4.37

Comments

@JeppeKlitgaard
Copy link
Contributor

Description

I am finding that AgGrid.get_client_data returns the unsorted and unfiltered data. This makes sense as it uses the api.forEachNode call internally. It would if the forEach method could be defined in the get_client_data call as an optional argument.

See: https://www.ag-grid.com/javascript-data-grid/accessing-data/

I will work on a PR that adds this
JeppeKlitgaard pushed a commit to JeppeKlitgaard/nicegui that referenced this issue Aug 23, 2024
feat: implement access method for get_client_data
5538732 
Allows access to client data in a way that also takes care of sorting and filtering.

Fixes: zauberzeug#3581
@JeppeKlitgaard JeppeKlitgaard mentioned this issue Aug 23, 2024
Merged
@falkoschindler falkoschindler added this to the 1.4.37 milestone Aug 26, 2024
@falkoschindler falkoschindler added the enhancement New feature or request label Aug 26, 2024
falkoschindler added a commit that referenced this issue Aug 28, 2024
@JeppeKlitgaard @falkoschindler
feat: implement access method for get_client_data (#3582)
c3f1ab1 
* feat: implement access method for get_client_data

Allows access to client data in a way that also takes care of sorting and filtering.

Fixes: #3581

* code review

* add pytest

---------

Co-authored-by: Jeppe Klitgaard <jkl@nanonord.dk>
Co-authored-by: Falko Schindler <falko@zauberzeug.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4.37
Development

Successfully merging a pull request may close this issue.

feat: implement access method for get_client_data JeppeKlitgaard/nicegui
2 participants
@JeppeKlitgaard @falkoschindler