Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: condense mypy and pytest config files to pyproject.toml #1053

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

xec-abailey
Copy link
Contributor

Per conversation here, starting in PEP 518 the pyproject.toml is beginning to become the centralized location for all configuration. Both mypy and pytest use it. This is in preparation for simplifying some of the dev environment to make contribution a bit smoother

@xec-abailey
Copy link
Contributor Author

xec-abailey commented Jun 21, 2023

@zauberzeug-dev by the way test discovery is still being funky for me due to dependencies somewhere - working through that with devcontainer stuff. That aside these configurations seem to be coming in fine through pyproject.toml

Copy link
Member

@rodja rodja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@rodja rodja merged commit c1a2f48 into zauberzeug:main Jun 21, 2023
@rodja rodja added this to the 1.2.22 milestone Jun 21, 2023
@rodja rodja added the enhancement New feature or request label Jun 21, 2023
@xec-abailey xec-abailey deleted the config-files-to-pyproject.toml branch June 21, 2023 14:58
@falkoschindler
Copy link
Contributor

I just noticed that pytest-watch doesn't work well with pyproject.toml (see joeyespo/pytest-watch#114).
Luckily, there is pytest-watcher. So we don't have to change anything. But if you're using ptw, make sure to switch to pytest-watcher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants