Fixed table selection not going away after removing selection in table_and_slots example #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_and_slots exmaple
|
Here is the tables_and_slots example being run after the fix (selection is cleared when items are removed): table_and_slots_test.mp4 |
rodja
added
bug
falkoschindler
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Thanks a lot for this pull request, @Trickshotblaster! The example was indeed a bit broken.
I took your approach one step further and moved the fix into the remove_rows method. This fixes not only the example, but any code using remove_rows. 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Remove button is clicked in the example, only the table content is changed, not the selection, as mentioned in this issue. The added remove_from_table function both removes the rows from the table, as well as clears the selection, with table.selected.clear(). This might not be the most optimized implementation, but it does successfully clear the selection.