Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following two issues regarding favicons:
The following code should use logo.png as favicon on "/":
But the route is incorrectly created at "//favicon.ico". By explicitly handling the index path "/" in
create_favicon_route()
, this bug is easily fixed.The following code should use logo.png as favicon on "/test":
But there is no favicon route created for "/test", because the page favicon is
None
. Instead the global favicon should be used. This is fixed by ignoring the page path inget_favicon_url()
in this case.