Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode for NiceGUI documentation #1164

Merged
merged 10 commits into from
Jul 17, 2023
Merged

Dark mode for NiceGUI documentation #1164

merged 10 commits into from
Jul 17, 2023

Conversation

falkoschindler
Copy link
Contributor

@falkoschindler falkoschindler commented Jul 13, 2023

Following up on the discussion #771 this PR implements dark mode support for the NiceGUI documentation website.

  • overall color adjustments
  • allow the user to switch between light/dark/auto
  • fix some colors for "auto" mode
  • adjust colors for code and browser windows
  • make ui.dark demo work with all global modes
  • use app.storage.browser, change setting via JavaScript calling a dedicated endpoint

@falkoschindler falkoschindler added this to the 1.3.2 milestone Jul 14, 2023
@falkoschindler falkoschindler added the documentation Improvements or additions to documentation label Jul 14, 2023
@falkoschindler falkoschindler self-assigned this Jul 14, 2023
@falkoschindler falkoschindler modified the milestones: 1.3.2, 1.3.3 Jul 14, 2023
@falkoschindler falkoschindler modified the milestones: 1.3.3, 1.3.4 Jul 15, 2023
@falkoschindler falkoschindler marked this pull request as ready for review July 16, 2023 14:18
@rodja rodja merged commit c100482 into main Jul 17, 2023
@falkoschindler falkoschindler deleted the dark branch July 17, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants