-
-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added storage dir path options #1426
Conversation
I think we should not use the temp directory as default to store persistent data. temp gets potentially cleaned a lot, and would defeat the purpose of the persistence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick PR, @Smug246! Just a few remarks:
- I have to agree with @rodja. At least in 1.3 we don't want to introduce breaking changes. So the default path should be the current working directory.
- And I slightly tend to the parameter name
storage_path
instead ofstorage_dir
to avoid an abbreviation and to indicate its path-like nature. - Last but not least we shouldn't forget to add this parameter to
ui.run_with
for when using NiceGUI with an existing FastAPI app.
np ill make those changes |
Thanks, @Smug246! I just made a few more changes:
A downside of these changes is the duplication of the default value |
Oh dear, I merged too early. The storage path is already used before |
This problem seems to be pretty fundamental. Therefore I reverted this PR and re-opened discussion #1418. |
From discussion #1418