catch gaierror and improve startup speed #1498
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #1178 by catching
gaierror
. the error can be reproduced by deactivating all sharing features on in the MacOS settings, restarting the laptop and deinstallingnetifaces
.While using this setup I noticed a significant delay of five seconds before NiceGUI really starts. This is caused by the default dns timeout on the hostname which seems not to be added to the /etc/hosts file if no sharing features are activated on MacOS (see https://apple.stackexchange.com/a/253834/26268). Making
netifaces
orpsutils
a dependency is not an option because it would require c++ and python-dev dependencies for building on some architectures. Thus I made the message printing async and hence independent of the startup.