Echarts onclick

[thetableman]

This PR adds the on_click_point functionality to Apache Echarts.

[rodja]

Why have you picked this subset of event arguments? Have you seen the uncycle function in chart.js?

[thetableman]

From what I could see in the documentation these are the options available in the response from the click event.
I saw the uncycle in chart.js but I'm not great with javascript and didn't understand it.

[rodja]

Ok, we will let @falkoschindler decide which variant we will integrate. Thanks!

[natankeddem]

@rodja
Should we close out my PR #1556 ?
This appears to add what I was going to do and then some more ancillary functionality.

[thetableman]

Don't want to steal you're thunder @natankeddem, I just had your code in my repo for testing when I committed my onclick PR.

[natankeddem]

No worries, I wanted to look further into the element testing and some other things. If you want to continue with this it will give me some time to do that. I will close my PR.

[rodja]

I'm also sorry @natankeddem. I haven't seen that this PR also includes the changes from #1556. But the same remarks I made in #1556 apply here: We will need tests and demos to the docs. I'll convert this to "Draft" for now. Maybe its simpler to reopen #1556 and let @thetableman create a new PR without the dynamic option conversion so we can work on both features separately?

[rodja]

We need demos and tests.

[thetableman]

We need demos and tests.

@rodja I can't find any tests for echarts at all in the main branch, we're any completed with the initial element PR?

[rodja]

You are right @thetableman. There where no tests added in #1346. It somehow slipped through. Maybe you can coordinate with @natankeddem? https://github.com/zauberzeug/nicegui/blob/main/tests/test_chart.py could be used as an inspiration.

[thetableman]

Yes, I was thinking of basing it on the test for ui.chart but it too is missing tests for the point click. I'm also struggling a bit to identify the css of the visual created by the ui.echart element - eg the css for a bar.

[natankeddem]

@thetableman Do you mind if we work together under your PR? You could add me as a collaborator. Since our contributions are interrelated it would probably be easier to manage. Also, it should be less heartburn on the maintainers with merging.
I suggest we concentrate on the following here, although I know echart has other issues:

• Implement dynamic parsing for options.
• Figure out the events we want and how to structure them.
• Implement full testing suite.
• Implement examples for any new functionality.

[natankeddem]

At first glance testing this element might be quite different than testing the chart element. echart utilizes a canvas element which makes extracting data more difficult than parsing the html that chart creates. This is my first major dive into this sort of testing so I need to research some more on this topic. This apache/echarts#13635 (comment) provides some insight into testing ECharts. It appears to boil down to needing to do graphical analysis of the rendered chart.

[thetableman]

@thetableman Do you mind if we work together under your PR? You could add me as a collaborator. Since our contributions are interrelated it would probably be easier to manage. Also, it should be less heartburn on the maintainers with merging. I suggest we concentrate on the following here, although I know echart has other issues:

* Implement dynamic parsing for options.

* Figure out the events we want and how to structure them.

* Implement full testing suite.

* Implement examples for any new functionality.

Sounds good @natankeddem!

I'll have to close this PR and submit another because the repo is located in an organization and I can't invite external collaborators, I'll invite you from a personal repo instead.

This will be an opportunity to reference the dynamic parsing as part of the new PR too.

New PR is #1579

[falkoschindler]

At first glance testing this element might be quite different than testing the chart element. echart utilizes a canvas element which makes extracting data more difficult than parsing the html that chart creates.

That's why I didn't insist on tests for #1346. But sure, it's always better to have them.