Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TabPanels.value type hint #1728

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

s2terminal
Copy link
Contributor

The ui.tab_panels argument value can be the name of a tab. There is an example in the documentation where the argument value of ui.tab_panels is given as a string.
However, the argument value of ui.tab_panels does not allow strings, and VS Code type checking, etc. will show an error.

image

Copy link
Contributor

@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks, @s2terminal!

@falkoschindler falkoschindler added this to the 1.3.16 milestone Oct 2, 2023
@falkoschindler falkoschindler merged commit 6d6af6b into zauberzeug:main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants